[libc][math] Enable math acos for baremetal Arm and AArch64 #166749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds `acos` to the entrypoints of baremetal Arm and AArch64. Tests have been run with Arm Toolchain for Embedded, a downstream toolchain, in conjunction with qemu, across several configurations of FPUs and architecture versions. All tests run are passing.
Member
|
@llvm/pr-subscribers-libc Author: Victor Campos (vhscampos) ChangesThis patch adds Tests have been run with Arm Toolchain for Embedded, a downstream toolchain, in conjunction with qemu, across several configurations of FPUs and architecture versions. All tests run are passing. Full diff: https://github.com/llvm/llvm-project/pull/166749.diff 2 Files Affected:
diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt
index 935c95af0d4af..b6650d79f624b 100644
--- a/libc/config/baremetal/aarch64/entrypoints.txt
+++ b/libc/config/baremetal/aarch64/entrypoints.txt
@@ -321,6 +321,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.fenv.feupdateenv
# math.h entrypoints
+ libc.src.math.acos
libc.src.math.acosf
libc.src.math.acoshf
libc.src.math.asinf
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index 82e257c1d2b0d..eedd9f7418f1f 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -321,6 +321,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.fenv.feupdateenv
# math.h entrypoints
+ libc.src.math.acos
libc.src.math.acosf
libc.src.math.acoshf
libc.src.math.asinf
|
lntue
approved these changes
Nov 6, 2025
petrhosek
approved these changes
Nov 6, 2025
vinay-deshmukh
pushed a commit
to vinay-deshmukh/llvm-project
that referenced
this pull request
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
acosto the entrypoints of baremetal Arm and AArch64.Tests have been run with Arm Toolchain for Embedded, a downstream toolchain, in conjunction with qemu, across several configurations of FPUs and architecture versions. All tests run are passing.