-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[DAGCombiner] Add sra-xor-sra pattern fold #166777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1d0ea8b
[DAGCombiner] add sra xor sra pattern fold
rez5427 9f2e1e3
Use sd_match
rez5427 66e06e7
Use m_Not
rez5427 17eeb2c
Address code review feedback
rez5427 6cdf735
Use getShiftAmountConstant
Yui5427 ff9b44f
Use getLimitedValue
rez5427 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py | ||
| ; RUN: llc -mtriple=riscv64 -verify-machineinstrs < %s | FileCheck %s | ||
|
|
||
| ; Test folding of: (sra (xor (sra x, c1), -1), c2) -> (sra (xor x, -1), c3) | ||
| ; Original motivating example: should merge sra+sra across xor | ||
| define i16 @not_invert_signbit_splat_mask(i8 %x, i16 %y) { | ||
| ; CHECK-LABEL: not_invert_signbit_splat_mask: | ||
| ; CHECK: # %bb.0: | ||
| ; CHECK-NEXT: slli a0, a0, 56 | ||
| ; CHECK-NEXT: srai a0, a0, 62 | ||
| ; CHECK-NEXT: not a0, a0 | ||
| ; CHECK-NEXT: and a0, a0, a1 | ||
| ; CHECK-NEXT: ret | ||
| %a = ashr i8 %x, 6 | ||
| %n = xor i8 %a, -1 | ||
| %s = sext i8 %n to i16 | ||
| %r = and i16 %s, %y | ||
| ret i16 %r | ||
| } | ||
|
|
||
| ; Edge case | ||
| define i16 @sra_xor_sra_overflow(i8 %x, i16 %y) { | ||
| ; CHECK-LABEL: sra_xor_sra_overflow: | ||
| ; CHECK: # %bb.0: | ||
| ; CHECK-NEXT: li a0, 0 | ||
| ; CHECK-NEXT: ret | ||
| %a = ashr i8 %x, 10 | ||
| %n = xor i8 %a, -1 | ||
| %s = sext i8 %n to i16 | ||
| %r = and i16 %s, %y | ||
| ret i16 %r | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.