Skip to content

Add a workaround for people that use *args instead of listing #166883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2025
+6 −1
Merged

Add a workaround for people that use *args instead of listing #166883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18ec347
Add a workaround for people that use *args instead of listing
jimingham Nov 7, 2025
d0b54a0
formatting
jimingham Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedPythonInterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,13 @@ class ScriptedPythonInterface : virtual public ScriptedInterface {
// This addresses the cases where the embedded interpreter session
// dictionary is passed to the extension initializer which is not used
// most of the time.
// Note, though none of our API's suggest defining the interfaces with
// varargs, we have some extant clients that were doing that. To keep
// from breaking them, we just say putting a varargs in these signatures
// turns off argument checking.
size_t num_args = sizeof...(Args);
if (num_args != arg_info->max_positional_args) {
if (arg_info->max_positional_args != PythonCallable::ArgInfo::UNBOUNDED &&
Copy link
Member

@JDevlieghere JDevlieghere Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we wanted to discourage this pattern, we could emit a warning with Debugger::ReportWarning. It takes an optional once_flag that would allow us to limit this warning to once per ScriptedPythonInterface instance or even once per lldb instance if we made it static.

Copy link
Collaborator Author

@jimingham jimingham Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's necessary. Someone did this once and then sadly that got copied around and so there are a few versions I need to maintain support for. I'm not sure this is something anyone else is likely to think is a good idea.

num_args != arg_info->max_positional_args) {
if (num_args != arg_info->max_positional_args - 1)
return create_error("Passed arguments ({0}) doesn't match the number "
"of expected arguments ({1}).",
Expand Down
Loading