Skip to content

[LLDB] Run MSVC STL (forward-)list test with PDB #166953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −0
Open

[LLDB] Run MSVC STL (forward-)list test with PDB #166953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lldb/source/Plugins/Language/CPlusPlus/GenericList.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,12 @@ lldb::ChildCacheState MsvcStlForwardListFrontEnd::Update() {
m_backend.GetChildAtNamePath({"_Mypair", "_Myval2", "_Myhead"}))
m_head = head_sp.get();

if (!m_element_type && m_head) {
auto val_sp = m_head->GetChildMemberWithName("_Myval");
if (val_sp)
m_element_type = val_sp->GetCompilerType();
}

return ChildCacheState::eRefetch;
}

Expand Down Expand Up @@ -606,6 +612,12 @@ lldb::ChildCacheState MsvcStlListFrontEnd::Update() {
m_head = first.get();
m_tail = last.get();

if (!m_element_type && m_head) {
auto val_sp = m_head->GetChildMemberWithName("_Myval");
if (val_sp)
m_element_type = val_sp->GetCompilerType();
}

return lldb::ChildCacheState::eRefetch;
}

Expand Down
2 changes: 2 additions & 0 deletions ...-formatter/data-formatter-stl/generic/forward_list/TestDataFormatterGenericForwardList.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@


class TestDataFormatterGenericForwardList(TestBase):
TEST_WITH_PDB_DEBUG_INFO = True

def setUp(self):
TestBase.setUp(self)
self.line = line_number("main.cpp", "// break here")
Expand Down
2 changes: 2 additions & 0 deletions ...ionalities/data-formatter/data-formatter-stl/generic/list/TestDataFormatterGenericList.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@


class GenericListDataFormatterTestCase(TestBase):
TEST_WITH_PDB_DEBUG_INFO = True

def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
Expand Down
1 change: 1 addition & 0 deletions ...s/data-formatter/data-formatter-stl/generic/list/loop/TestDataFormatterGenericListLoop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@


class GenericListDataFormatterTestCase(TestBase):
TEST_WITH_PDB_DEBUG_INFO = True
NO_DEBUG_INFO_TESTCASE = True

def do_test_with_run_command(self):
Expand Down
Loading