Skip to content

Conversation

@quic-areg
Copy link
Contributor

@quic-areg quic-areg commented Nov 7, 2025

Attributes for v79 and 81 were recorded but ignored.

@llvmbot
Copy link
Member

llvmbot commented Nov 7, 2025

@llvm/pr-subscribers-llvm-binary-utilities

Author: None (quic-areg)

Changes

Attributes for v77-81 were recorded but ignored.


Full diff: https://github.com/llvm/llvm-project/pull/166992.diff

1 Files Affected:

  • (modified) llvm/lib/Object/ELFObjectFile.cpp (+6)
diff --git a/llvm/lib/Object/ELFObjectFile.cpp b/llvm/lib/Object/ELFObjectFile.cpp
index f9fda23469ee5..178b557c38541 100644
--- a/llvm/lib/Object/ELFObjectFile.cpp
+++ b/llvm/lib/Object/ELFObjectFile.cpp
@@ -311,6 +311,12 @@ static std::optional<std::string> hexagonAttrToFeatureString(unsigned Attr) {
     return "v73";
   case 75:
     return "v75";
+  case 77:
+    return "v77";
+  case 79:
+    return "v79";
+  case 81:
+    return "v81";
   default:
     return {};
   }

return "v73";
case 75:
return "v75";
case 77:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should V77 be removed?

Attributes for v77-81 were recorded but ignored.
@iajbar
Copy link
Contributor

iajbar commented Nov 7, 2025

Please remove v77 from "Attributes for v77-81 were recorded but ignored."

@quic-areg quic-areg merged commit 682c8e2 into llvm:main Nov 7, 2025
9 of 10 checks passed
@quic-areg quic-areg deleted the missing-attrs branch November 7, 2025 21:09
vinay-deshmukh pushed a commit to vinay-deshmukh/llvm-project that referenced this pull request Nov 8, 2025
Attributes for v79 and 81 were recorded but ignored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants