Skip to content

Conversation

@kazutakahirata
Copy link
Contributor

initializeNVPTXCtorDtorLoweringLegacyPass is declared twice in
NVPTX.h.

initializeGenericToNVVMLegacyPassPass is declared in NVPTX.h.

Identified with readability-redundant-declaration.

initializeNVPTXCtorDtorLoweringLegacyPass is declared twice in
NVPTX.h.

initializeGenericToNVVMLegacyPassPass is declared in NVPTX.h.

Identified with readability-redundant-declaration.
@llvmbot
Copy link
Member

llvmbot commented Nov 8, 2025

@llvm/pr-subscribers-backend-nvptx

Author: Kazu Hirata (kazutakahirata)

Changes

initializeNVPTXCtorDtorLoweringLegacyPass is declared twice in
NVPTX.h.

initializeGenericToNVVMLegacyPassPass is declared in NVPTX.h.

Identified with readability-redundant-declaration.


Full diff: https://github.com/llvm/llvm-project/pull/167153.diff

2 Files Affected:

  • (modified) llvm/lib/Target/NVPTX/NVPTX.h (-1)
  • (modified) llvm/lib/Target/NVPTX/NVPTXGenericToNVVM.cpp (-4)
diff --git a/llvm/lib/Target/NVPTX/NVPTX.h b/llvm/lib/Target/NVPTX/NVPTX.h
index 1e0f747f8f7fc..95fd05f2a926f 100644
--- a/llvm/lib/Target/NVPTX/NVPTX.h
+++ b/llvm/lib/Target/NVPTX/NVPTX.h
@@ -66,7 +66,6 @@ void initializeNVPTXCtorDtorLoweringLegacyPass(PassRegistry &);
 void initializeNVPTXLowerAggrCopiesPass(PassRegistry &);
 void initializeNVPTXLowerAllocaPass(PassRegistry &);
 void initializeNVPTXLowerUnreachablePass(PassRegistry &);
-void initializeNVPTXCtorDtorLoweringLegacyPass(PassRegistry &);
 void initializeNVPTXLowerArgsLegacyPassPass(PassRegistry &);
 void initializeNVPTXProxyRegErasurePass(PassRegistry &);
 void initializeNVPTXForwardParamsPassPass(PassRegistry &);
diff --git a/llvm/lib/Target/NVPTX/NVPTXGenericToNVVM.cpp b/llvm/lib/Target/NVPTX/NVPTXGenericToNVVM.cpp
index c734d3d430073..7f190f33da808 100644
--- a/llvm/lib/Target/NVPTX/NVPTXGenericToNVVM.cpp
+++ b/llvm/lib/Target/NVPTX/NVPTXGenericToNVVM.cpp
@@ -28,10 +28,6 @@
 
 using namespace llvm;
 
-namespace llvm {
-void initializeGenericToNVVMLegacyPassPass(PassRegistry &);
-}
-
 namespace {
 class GenericToNVVM {
 public:

@kazutakahirata kazutakahirata merged commit ae1622a into llvm:main Nov 8, 2025
12 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_20251108_clang_tidy_readability-redundant-declaration_NVPTX branch November 8, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants