[NFC] DWARFVerifier: use C-style array instead of brace-enclosed init list #167328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… list Historically, MSVC would issue a warning seeing a brace-enclosed initializer list variable being used as a range. A quick fix is to use a C-style array instead which is more or less an equivalent form. Unfortunately, a lot of time has passed since this patch was originally added to our downstream. Thus, the original warning is long lost. The patch is trivial and harmless enough to be applied nonetheless. Co-authored-by: Jörn Schöndube <jorn.schondube@intel.com>
Member
|
@llvm/pr-subscribers-debuginfo Author: Andrei Golubev (andrey-golubev) ChangesHistorically, MSVC would issue a warning seeing a brace-enclosed initializer list variable being used as a range. A quick fix is to use a C-style array instead which is more or less an equivalent form. Unfortunately, a lot of time has passed since this patch was originally added to our downstream. Thus, the original warning is long lost. The patch is trivial and harmless enough to be applied nonetheless. Full diff: https://github.com/llvm/llvm-project/pull/167328.diff 1 Files Affected:
diff --git a/llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp b/llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
index 693454e249945..440ad4f1268c7 100644
--- a/llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
+++ b/llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
@@ -1523,8 +1523,8 @@ void DWARFVerifier::verifyNameIndexAttribute(
}
if (AttrEnc.Index == dwarf::DW_IDX_parent) {
- constexpr static auto AllowedForms = {dwarf::Form::DW_FORM_flag_present,
- dwarf::Form::DW_FORM_ref4};
+ constexpr static dwarf::Form AllowedForms[] = {
+ dwarf::Form::DW_FORM_flag_present, dwarf::Form::DW_FORM_ref4};
if (!is_contained(AllowedForms, AttrEnc.Form)) {
ErrorCategory.Report("Unexpected NameIndex Abbreviation", [&]() {
error() << formatv(
|
Contributor
Author
|
Gentle ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, MSVC would issue a warning seeing a brace-enclosed initializer list variable being used as a range. A quick fix is to use a C-style array instead which is more or less an equivalent form.
Unfortunately, a lot of time has passed since this patch was originally added to our downstream. Thus, the original warning is long lost. The patch is trivial and harmless enough to be applied nonetheless.