workflows/release-binaries: Drop use of setup-windows action #167440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't actually support Windows builds at this time, so this is not needed. I plan to add a different implementation once the release-binaries workflow supports Windows again.
Member
|
@llvm/pr-subscribers-github-workflow Author: Tom Stellard (tstellar) ChangesWe don't actually support Windows builds at this time, so this is not needed. I plan to add a different implementation once the release-binaries workflow supports Windows again. Full diff: https://github.com/llvm/llvm-project/pull/167440.diff 1 Files Affected:
diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml
index a4a462ae6737c..1ffa088e99fa1 100644
--- a/.github/workflows/release-binaries.yml
+++ b/.github/workflows/release-binaries.yml
@@ -191,12 +191,6 @@ jobs:
- name: Install Ninja
uses: llvm/actions/install-ninja@42d80571b13f4599bbefbc7189728b64723c7f78 # main
- - name: Setup Windows
- if: startsWith(runner.os, 'Windows')
- uses: llvm/actions/setup-windows@42d80571b13f4599bbefbc7189728b64723c7f78 # main
- with:
- arch: amd64
-
- name: Set Build Prefix
id: setup-stage
shell: bash
|
boomanaiden154
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't actually support Windows builds at this time, so this is not needed. I plan to add a different implementation once the release-binaries workflow supports Windows again.