Skip to content

[ARM][BPF][Lanai][MSP430] Use MCRegister::id() to avoid an implicit cast. NFC #167537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2025
Merged

[ARM][BPF][Lanai][MSP430] Use MCRegister::id() to avoid an implicit cast. NFC #167537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd10d2c
[BPF][Lanai][MSP430] Use MCRegister::id() to avoid an implicit cast. NFC
topperc Nov 11, 2025
e7a892f
fixup! Add a case in ARM.
topperc Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,7 +1238,7 @@ uint64_t ARMAsmBackendDarwin::generateCompactUnwindEncoding(
// Verify standard frame (lr/r7) was used.
if (CFARegister != ARM::R7) {
DEBUG_WITH_TYPE("compact-unwind", llvm::dbgs() << "frame register is "
<< CFARegister
<< CFARegister.id()
<< " instead of r7\n");
return CU::UNWIND_ARM_MODE_DWARF;
}
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/Target/BPF/AsmParser/BPFAsmParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ struct BPFOperand : public MCParsedAsmOperand {
break;
case Register:
OS << "<register x";
OS << getReg() << ">";
OS << getReg().id() << ">";
break;
case Token:
OS << "'" << getToken() << "'";
Expand Down
8 changes: 4 additions & 4 deletions llvm/lib/Target/Lanai/AsmParser/LanaiAsmParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,22 +559,22 @@ struct LanaiOperand : public MCParsedAsmOperand {
OS << "Token: " << getToken() << "\n";
break;
case REGISTER:
OS << "Reg: %r" << getReg() << "\n";
OS << "Reg: %r" << getReg().id() << "\n";
break;
case MEMORY_IMM:
OS << "MemImm: ";
MAI.printExpr(OS, *getMemOffset());
OS << '\n';
break;
case MEMORY_REG_IMM:
OS << "MemRegImm: " << getMemBaseReg() << "+";
OS << "MemRegImm: " << getMemBaseReg().id() << "+";
MAI.printExpr(OS, *getMemOffset());
OS << '\n';
break;
case MEMORY_REG_REG:
assert(getMemOffset() == nullptr);
OS << "MemRegReg: " << getMemBaseReg() << "+"
<< "%r" << getMemOffsetReg() << "\n";
OS << "MemRegReg: " << getMemBaseReg().id() << "+"
<< "%r" << getMemOffsetReg().id() << "\n";
break;
}
}
Expand Down
6 changes: 3 additions & 3 deletions llvm/lib/Target/MSP430/AsmParser/MSP430AsmParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ class MSP430Operand : public MCParsedAsmOperand {
O << "Token " << Tok;
break;
case k_Reg:
O << "Register " << Reg;
O << "Register " << Reg.id();
break;
case k_Imm:
O << "Immediate ";
Expand All @@ -241,10 +241,10 @@ class MSP430Operand : public MCParsedAsmOperand {
MAI.printExpr(O, *Mem.Offset);
break;
case k_IndReg:
O << "RegInd " << Reg;
O << "RegInd " << Reg.id();
break;
case k_PostIndReg:
O << "PostInc " << Reg;
O << "PostInc " << Reg.id();
break;
}
}
Expand Down
Loading