-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[Github] Make bazel workflow run all tests #167576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Now that the caching seems to be working reasonably well, enable building and testing the entirety of the project to actually catch most of the build configuration issues that this workflow is intended to catch.
|
This should work once #167711 lands. I'll make sure to rerun once that lands. |
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesNow that the caching seems to be working reasonably well, enable building and testing the entirety of the project to actually catch most of the build configuration issues that this workflow is intended to catch. Full diff: https://github.com/llvm/llvm-project/pull/167576.diff 1 Files Affected:
diff --git a/.github/workflows/bazel-checks.yml b/.github/workflows/bazel-checks.yml
index 1b27dbc1dbc4d..348168951ba6f 100644
--- a/.github/workflows/bazel-checks.yml
+++ b/.github/workflows/bazel-checks.yml
@@ -44,7 +44,7 @@ jobs:
- name: Setup System Dependencies
run: |
sudo apt-get update
- sudo apt-get install -y libmpfr-dev libpfm4-dev
+ sudo apt-get install -y libmpfr-dev libpfm4-dev m4
sudo curl -L https://github.com/bazelbuild/bazelisk/releases/download/v1.27.0/bazelisk-amd64.deb > /tmp/bazelisk.deb
sudo apt-get install -y /tmp/bazelisk.deb
rm /tmp/bazelisk.deb
@@ -54,4 +54,4 @@ jobs:
bazelisk test --config=ci --sandbox_base="" \
--remote_cache=https://storage.googleapis.com/$CACHE_GCS_BUCKET-bazel \
--google_default_credentials \
- @llvm-project//llvm/unittests:adt_tests
+ @llvm-project//...
|
rupprecht
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 20m isn't the greatest, but hopefully it's usually much quicker if the cache kicks in?
Yeah, it should be quite a bit faster with cache. |
|
Yeah, looks like ~5 minutes with a reasonably warm cache. Should be ~1 minute if there aren't any code changes any between runs. |
|
Eh, more like 2.5 minutes with a really warm build. |
Now that the caching seems to be working reasonably well, enable building and testing the entirety of the project to actually catch most of the build configuration issues that this workflow is intended to catch.
Now that the caching seems to be working reasonably well, enable building and testing the entirety of the project to actually catch most of the build configuration issues that this workflow is intended to catch.