Skip to content

Conversation

@boomanaiden154
Copy link
Contributor

Now that the caching seems to be working reasonably well, enable building and testing the entirety of the project to actually catch most of the build configuration issues that this workflow is intended to catch.

Now that the caching seems to be working reasonably well, enable
building and testing the entirety of the project to actually catch most
of the build configuration issues that this workflow is intended to
catch.
@boomanaiden154 boomanaiden154 marked this pull request as ready for review November 12, 2025 16:11
@boomanaiden154
Copy link
Contributor Author

This should work once #167711 lands. I'll make sure to rerun once that lands.

@llvmbot
Copy link
Member

llvmbot commented Nov 12, 2025

@llvm/pr-subscribers-github-workflow

Author: Aiden Grossman (boomanaiden154)

Changes

Now that the caching seems to be working reasonably well, enable building and testing the entirety of the project to actually catch most of the build configuration issues that this workflow is intended to catch.


Full diff: https://github.com/llvm/llvm-project/pull/167576.diff

1 Files Affected:

  • (modified) .github/workflows/bazel-checks.yml (+2-2)
diff --git a/.github/workflows/bazel-checks.yml b/.github/workflows/bazel-checks.yml
index 1b27dbc1dbc4d..348168951ba6f 100644
--- a/.github/workflows/bazel-checks.yml
+++ b/.github/workflows/bazel-checks.yml
@@ -44,7 +44,7 @@ jobs:
       - name: Setup System Dependencies
         run: |
           sudo apt-get update
-          sudo apt-get install -y libmpfr-dev libpfm4-dev
+          sudo apt-get install -y libmpfr-dev libpfm4-dev m4
           sudo curl -L https://github.com/bazelbuild/bazelisk/releases/download/v1.27.0/bazelisk-amd64.deb > /tmp/bazelisk.deb
           sudo apt-get install -y /tmp/bazelisk.deb
           rm /tmp/bazelisk.deb
@@ -54,4 +54,4 @@ jobs:
           bazelisk test --config=ci --sandbox_base="" \
             --remote_cache=https://storage.googleapis.com/$CACHE_GCS_BUCKET-bazel \
             --google_default_credentials \
-            @llvm-project//llvm/unittests:adt_tests
+            @llvm-project//...

Copy link
Collaborator

@rupprecht rupprecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 20m isn't the greatest, but hopefully it's usually much quicker if the cache kicks in?

@boomanaiden154
Copy link
Contributor Author

but hopefully it's usually much quicker if the cache kicks in?

Yeah, it should be quite a bit faster with cache.

@boomanaiden154
Copy link
Contributor Author

Yeah, looks like ~5 minutes with a reasonably warm cache. Should be ~1 minute if there aren't any code changes any between runs.

@boomanaiden154
Copy link
Contributor Author

Eh, more like 2.5 minutes with a really warm build.

@boomanaiden154 boomanaiden154 merged commit 919bff7 into llvm:main Nov 12, 2025
16 checks passed
@boomanaiden154 boomanaiden154 deleted the bazel-fullbuild branch November 12, 2025 21:02
git-crd pushed a commit to git-crd/crd-llvm-project that referenced this pull request Nov 13, 2025
Now that the caching seems to be working reasonably well, enable
building and testing the entirety of the project to actually catch most
of the build configuration issues that this workflow is intended to
catch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants