[libclc] Fix floating-point __clc_atomic_store/exchange cast mismatch #167625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pointer element type is casted to integer type, the stored value
should be casted to integer type to avoid type mistmatch.
LLVM IR change in function _Z18__clc_atomic_storePU3AS1Vffii:
> %5 = bitcast float %1 to i32 (New)
< %5 = fptosi float %1 to i32 (Old)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a type mismatch in the __clc_atomic_store function for floating-point types. The issue occurs when a floating-point pointer is cast to an integer pointer type, but the stored value wasn't being properly converted from floating-point to integer representation using bitcast semantics.
- Introduces
__CLC_AS_INTTYPEmacro to properly cast the stored value to match the pointer's cast type - Applies the integer type conversion to the
Valueparameter in atomic store operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libclc/clc/lib/generic/atomic/clc_atomic_store.cl | Defines __CLC_AS_INTTYPE macro to enable proper type conversion for atomic store values |
| libclc/clc/lib/generic/atomic/clc_atomic_def.inc | Adds default __CLC_AS_INTTYPE macro definition and applies it to the Value parameter in the store operation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arsenm
approved these changes
Nov 12, 2025
wenju-he
changed the title
arsenm
approved these changes
Nov 12, 2025
git-crd
pushed a commit
to git-crd/crd-llvm-project
that referenced
this pull request
Nov 13, 2025
…llvm#167625) When pointer element type is casted to integer type, the stored value should be casted to integer type to avoid type mistmatch. LLVM IR change in function _Z18__clc_atomic_storePU3AS1Vffii: > %5 = bitcast float %1 to i32 (New) < %5 = fptosi float %1 to i32 (Old)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pointer element type is casted to integer type, the stored value should be casted to integer type to avoid type mistmatch. LLVM IR change in function _Z18__clc_atomic_storePU3AS1Vffii:
> %5 = bitcast float %1 to i32 (New)
< %5 = fptosi float %1 to i32 (Old)