Skip to content

[AsmPrinter] Replace improper use of Register with MCRegUnit (NFC) #167682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

[AsmPrinter] Replace improper use of Register with MCRegUnit (NFC) #167682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,9 +589,9 @@ struct FwdRegParamInfo {

/// Register worklist for finding call site values.
using FwdRegWorklist = MapVector<uint64_t, SmallVector<FwdRegParamInfo, 2>>;
/// Container for the set of registers known to be clobbered on the path to a
/// call site.
using ClobberedRegSet = SmallSet<Register, 16>;
/// Container for the set of register units known to be clobbered on the path
/// to a call site.
using ClobberedRegUnitSet = SmallSet<MCRegUnit, 16>;

/// Append the expression \p Addition to \p Original and return the result.
static const DIExpression *combineDIExpressions(const DIExpression *Original,
Expand Down Expand Up @@ -663,7 +663,7 @@ static void addToFwdRegWorklist(FwdRegWorklist &Worklist, unsigned Reg,
static void interpretValues(const MachineInstr *CurMI,
FwdRegWorklist &ForwardedRegWorklist,
ParamSet &Params,
ClobberedRegSet &ClobberedRegUnits) {
ClobberedRegUnitSet &ClobberedRegUnits) {

const MachineFunction *MF = CurMI->getMF();
const DIExpression *EmptyExpr =
Expand Down Expand Up @@ -695,7 +695,7 @@ static void interpretValues(const MachineInstr *CurMI,

// If the MI is an instruction defining one or more parameters' forwarding
// registers, add those defines.
ClobberedRegSet NewClobberedRegUnits;
ClobberedRegUnitSet NewClobberedRegUnits;
auto getForwardingRegsDefinedByMI = [&](const MachineInstr &MI,
SmallSetVector<unsigned, 4> &Defs) {
if (MI.isDebugInstr())
Expand Down Expand Up @@ -778,7 +778,7 @@ static void interpretValues(const MachineInstr *CurMI,
static bool interpretNextInstr(const MachineInstr *CurMI,
FwdRegWorklist &ForwardedRegWorklist,
ParamSet &Params,
ClobberedRegSet &ClobberedRegUnits) {
ClobberedRegUnitSet &ClobberedRegUnits) {
// Skip bundle headers.
if (CurMI->isBundle())
return true;
Expand Down Expand Up @@ -848,7 +848,7 @@ static void collectCallSiteParameters(const MachineInstr *CallMI,
bool ShouldTryEmitEntryVals = MBB->getIterator() == MF->begin();

// Search for a loading value in forwarding registers inside call delay slot.
ClobberedRegSet ClobberedRegUnits;
ClobberedRegUnitSet ClobberedRegUnits;
if (CallMI->hasDelaySlot()) {
auto Suc = std::next(CallMI->getIterator());
// Only one-instruction delay slot is supported.
Expand Down
Loading