Skip to content

Conversation

@boomanaiden154
Copy link
Contributor

This was preventing check-compiler-rt from actually running when we touched a project that was supposed to cause compiler-rt to be tested.

This was preventing check-compiler-rt from actually running when we
touched a project that was supposed to cause compiler-rt to be tested.
@llvmbot llvmbot added the infrastructure Bugs about LLVM infrastructure label Nov 12, 2025
@llvmbot
Copy link
Member

llvmbot commented Nov 12, 2025

@llvm/pr-subscribers-infrastructure

Author: Aiden Grossman (boomanaiden154)

Changes

This was preventing check-compiler-rt from actually running when we touched a project that was supposed to cause compiler-rt to be tested.


Full diff: https://github.com/llvm/llvm-project/pull/167696.diff

1 Files Affected:

  • (modified) .ci/monolithic-windows.sh (+1-1)
diff --git a/.ci/monolithic-windows.sh b/.ci/monolithic-windows.sh
index beaed71f49f65..7b926b87f3623 100755
--- a/.ci/monolithic-windows.sh
+++ b/.ci/monolithic-windows.sh
@@ -55,7 +55,7 @@ start-group "ninja"
 ninja -C "${BUILD_DIR}" -k 0 ${targets} |& tee ninja.log
 cp ${BUILD_DIR}/.ninja_log ninja.ninja_log
 
-if [[ "${runtime_targets}" != "" ]]; then
+if [[ "${runtimes_targets}" != "" ]]; then
   start-group "ninja runtimes"
   
   ninja -C "${BUILD_DIR}" -k 0 ${runtimes_targets} |& tee ninja_runtimes.log

Copy link
Collaborator

@zmodem zmodem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Let's see what the bot says; there may be issues since it hasn't run these before.

@boomanaiden154
Copy link
Contributor Author

Let's see what the bot says; there may be issues since it hasn't run these before.

Ah, yep. Looks like test failures because the newer version of VS in the premerge CI marks some libc functions as deprecated in favor of the annex k versions...

Should be a simple fix. It seems like the sanitizer-windows bot has kept things reasonable enough in the mean time.

@boomanaiden154 boomanaiden154 enabled auto-merge (squash) November 13, 2025 02:09
@boomanaiden154 boomanaiden154 merged commit 147e615 into llvm:main Nov 13, 2025
14 of 15 checks passed
@boomanaiden154 boomanaiden154 deleted the fix-misspelling-windows-ci branch November 13, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Bugs about LLVM infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants