Skip to content

Conversation

@jansvoboda11
Copy link
Contributor

Pointed out in code review downstream: swiftlang#11816

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Nov 14, 2025
@jansvoboda11 jansvoboda11 merged commit cdbf243 into llvm:main Nov 14, 2025
7 of 11 checks passed
@jansvoboda11 jansvoboda11 deleted the ci-visit-paths-output-file branch November 14, 2025 00:32
@llvmbot
Copy link
Member

llvmbot commented Nov 14, 2025

@llvm/pr-subscribers-clang

Author: Jan Svoboda (jansvoboda11)

Changes

Pointed out in code review downstream: swiftlang#11816


Full diff: https://github.com/llvm/llvm-project/pull/167983.diff

1 Files Affected:

  • (modified) clang/lib/Frontend/CompilerInvocation.cpp (+1)
diff --git a/clang/lib/Frontend/CompilerInvocation.cpp b/clang/lib/Frontend/CompilerInvocation.cpp
index a95796924311b..54b302e829e1f 100644
--- a/clang/lib/Frontend/CompilerInvocation.cpp
+++ b/clang/lib/Frontend/CompilerInvocation.cpp
@@ -5322,6 +5322,7 @@ void CompilerInvocationBase::visitPathsImpl(
 
     RETURN_IF(Input.File);
   }
+  // TODO: Also report output files such as FrontendOpts.OutputFile;
   RETURN_IF(FrontendOpts.CodeCompletionAt.FileName);
   RETURN_IF_MANY(FrontendOpts.ModuleMapFiles);
   RETURN_IF_MANY(FrontendOpts.ModuleFiles);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants