Skip to content

[Scalar] Avoid deep copies of DenseMap (NFC) #168012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

[Scalar] Avoid deep copies of DenseMap (NFC) #168012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions llvm/lib/Transforms/Scalar/GVNSink.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ class ModelledPHI {
for (unsigned I = 0, E = PN->getNumIncomingValues(); I != E; ++I)
Ops.push_back({PN->getIncomingBlock(I), PN->getIncomingValue(I)});

auto ComesBefore = [BlockOrder](OpsType O1, OpsType O2) {
auto ComesBefore = [&](OpsType O1, OpsType O2) {
return BlockOrder.lookup(O1.first) < BlockOrder.lookup(O2.first);
};
// Sort in a deterministic order.
Expand All @@ -167,8 +167,8 @@ class ModelledPHI {
verifyModelledPHI(const DenseMap<const BasicBlock *, unsigned> &BlockOrder) {
assert(Values.size() > 1 && Blocks.size() > 1 &&
"Modelling PHI with less than 2 values");
auto ComesBefore = [BlockOrder](const BasicBlock *BB1,
const BasicBlock *BB2) {
[[maybe_unused]] auto ComesBefore = [&](const BasicBlock *BB1,
const BasicBlock *BB2) {
return BlockOrder.lookup(BB1) < BlockOrder.lookup(BB2);
};
assert(llvm::is_sorted(Blocks, ComesBefore));
Expand Down
Loading