Skip to content

Conversation

@kazutakahirata
Copy link
Contributor

ISD.Symbol is already of type MCSymbolMachO *.

Identified with readability-redundant-casting.

ISD.Symbol is already of type MCSymbolMachO *.

Identified with readability-redundant-casting.
@llvmbot llvmbot added the llvm:mc Machine (object) code label Nov 14, 2025
@llvmbot
Copy link
Member

llvmbot commented Nov 14, 2025

@llvm/pr-subscribers-llvm-mc

Author: Kazu Hirata (kazutakahirata)

Changes

ISD.Symbol is already of type MCSymbolMachO *.

Identified with readability-redundant-casting.


Full diff: https://github.com/llvm/llvm-project/pull/168013.diff

1 Files Affected:

  • (modified) llvm/lib/MC/MachObjectWriter.cpp (+1-2)
diff --git a/llvm/lib/MC/MachObjectWriter.cpp b/llvm/lib/MC/MachObjectWriter.cpp
index a8535dfa8a5d3..b42155d18bf0a 100644
--- a/llvm/lib/MC/MachObjectWriter.cpp
+++ b/llvm/lib/MC/MachObjectWriter.cpp
@@ -570,8 +570,7 @@ void MachObjectWriter::bindIndirectSymbols(MCAssembler &Asm) {
     //
     // FIXME: Do not hardcode.
     if (Asm.registerSymbol(*ISD.Symbol))
-      static_cast<MCSymbolMachO *>(ISD.Symbol)
-          ->setReferenceTypeUndefinedLazy(true);
+      ISD.Symbol->setReferenceTypeUndefinedLazy(true);
   }
 }
 

@kazutakahirata kazutakahirata merged commit daa1b60 into llvm:main Nov 14, 2025
11 of 12 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_20251113_clang_tidy_readability-redundant-casting branch November 14, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llvm:mc Machine (object) code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants