Skip to content

[Clang][ThreadSafety] Contextualize FieldDecl references in thread sa… #168028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

[Clang][ThreadSafety] Contextualize FieldDecl references in thread sa… #168028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions clang/lib/Analysis/ThreadSafetyCommon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,13 @@ til::SExpr *SExprBuilder::translateDeclRefExpr(const DeclRefExpr *DRE,
if (const auto *VarD = dyn_cast<VarDecl>(VD))
return translateVariable(VarD, Ctx);

if (const auto *FD = dyn_cast<FieldDecl>(VD)) {
if (Ctx && Ctx->SelfArg) {
til::SExpr *E = new (Arena) til::SApply(SelfVar);
return new (Arena) til::Project(E, FD);
}
}

// For non-local variables, treat it as a reference to a named object.
return new (Arena) til::LiteralPtr(VD);
}
Expand Down
4 changes: 0 additions & 4 deletions clang/test/SemaCXX/warn-thread-safety-analysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3590,14 +3590,10 @@ void requireDecl(RelockableScope &scope) {
struct foo
{
Mutex mu;
// expected-note@+1{{see attribute on parameter here}}
void require(RelockableScope &scope EXCLUSIVE_LOCKS_REQUIRED(mu));
void callRequire(){
RelockableScope scope(&mu);
// TODO: False positive due to incorrect parsing of parameter attribute arguments.
require(scope);
// expected-warning@-1{{calling function 'require' requires holding mutex 'mu' exclusively}}
// expected-warning@-2{{mutex managed by 'scope' is 'mu' instead of 'mu'}}
}
};

Expand Down
Loading