Skip to content

[clang][bytecode][NFC] Check pointer types in canClassify() #168069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

[clang][bytecode][NFC] Check pointer types in canClassify() #168069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions clang/lib/AST/ByteCode/Context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,20 +98,22 @@ class Context final {
return classify(E->getType());
}

bool canClassify(QualType T) {
bool canClassify(QualType T) const {
if (const auto *BT = dyn_cast<BuiltinType>(T)) {
if (BT->isInteger() || BT->isFloatingPoint())
return true;
if (BT->getKind() == BuiltinType::Bool)
return true;
}
if (T->isPointerOrReferenceType())
return true;

if (T->isArrayType() || T->isRecordType() || T->isAnyComplexType() ||
T->isVectorType())
return false;
return classify(T) != std::nullopt;
}
bool canClassify(const Expr *E) {
bool canClassify(const Expr *E) const {
if (E->isGLValue())
return true;
return canClassify(E->getType());
Expand Down
Loading