[libc] Allow user-defined LIBC_ASSERT macro. #168087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BC_ASSERT macro is not defined.
Member
|
@llvm/pr-subscribers-libc Author: None (lntue) ChangesBy only defining it if LIBC_ASSERT macro is not defined. Fixes #162392 Full diff: https://github.com/llvm/llvm-project/pull/168087.diff 1 Files Affected:
diff --git a/libc/src/__support/libc_assert.h b/libc/src/__support/libc_assert.h
index ada1795ccb80a..6e0b5bd3d68b4 100644
--- a/libc/src/__support/libc_assert.h
+++ b/libc/src/__support/libc_assert.h
@@ -14,9 +14,11 @@
// The build is configured to just use the public <assert.h> API
// for libc's internal assertions.
+#ifndef LIBC_ASSERT
#include <assert.h>
#define LIBC_ASSERT(COND) assert(COND)
+#endif // LIBC_ASSERT
#else // Not LIBC_COPT_USE_C_ASSERT
|
ldionne
reviewed
Nov 14, 2025
Member
ldionne
left a comment
ldionne
left a comment
There was a problem hiding this comment.
Just curious, what is LIBC_COPT_USE_C_ASSERT?
Contributor
It selects if we want to use the public C assert API or our own internal API for assertions. |
Contributor
Author
It is to skip the internal implementation of assertion in full build mode, mostly to be used in GPU offload or embedded systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By only defining it if LIBC_ASSERT macro is not defined.
Fixes #162392