lldb: Link delayimp on Windows #168093
Merged
lldb: Link delayimp on Windows #168093
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed when building with `LLVM_LINK_LLVM_DYLIB` to build LLVM as a DLL on Windows. This effort is tracked in llvm#109483.
Member
|
@llvm/pr-subscribers-lldb Author: Fabrice de Gans (Steelskin) ChangesThis is needed when building with This effort is tracked in #109483. Full diff: https://github.com/llvm/llvm-project/pull/168093.diff 1 Files Affected:
diff --git a/lldb/cmake/modules/AddLLDB.cmake b/lldb/cmake/modules/AddLLDB.cmake
index 5d58abf237f58..6493df27f38db 100644
--- a/lldb/cmake/modules/AddLLDB.cmake
+++ b/lldb/cmake/modules/AddLLDB.cmake
@@ -172,6 +172,7 @@ function(add_lldb_executable name)
if(NOT LIBLLDB_INDEX EQUAL -1)
if (MSVC)
target_link_options(${name} PRIVATE "/DELAYLOAD:$<TARGET_FILE_NAME:liblldb>")
+ target_link_libraries(${name} PRIVATE delayimp)
elseif (MINGW AND LINKER_IS_LLD)
# LLD can delay load just by passing a --delayload flag, as long as the import
# library is a short type import library (which LLD and MS link.exe produce).
|
charles-zablit
approved these changes
Nov 14, 2025
Contributor
Author
|
Could one of you land this for me, please? I do not have the rights. |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/195/builds/17351 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed when building with
LLVM_LINK_LLVM_DYLIBto build LLVM as a DLL on Windows.This effort is tracked in #109483.