-
Notifications
You must be signed in to change notification settings - Fork 15.2k
llvm: Export ilist_node_base template specialization
#168094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvm: Export ilist_node_base template specialization
#168094
Conversation
The core LLVM library implements a specialization for `ilist_node_base<true, void>`, which is used by other components. This is needed to link properly when building LLVM as a library on Windows. This effort is tracked in llvm#109483.
|
@llvm/pr-subscribers-llvm-adt Author: Fabrice de Gans (Steelskin) ChangesThe core LLVM library implements a specialization for This effort is tracked in #109483. Full diff: https://github.com/llvm/llvm-project/pull/168094.diff 1 Files Affected:
diff --git a/llvm/include/llvm/ADT/ilist_node_base.h b/llvm/include/llvm/ADT/ilist_node_base.h
index 49b197d3466d9..937e7d060e489 100644
--- a/llvm/include/llvm/ADT/ilist_node_base.h
+++ b/llvm/include/llvm/ADT/ilist_node_base.h
@@ -67,6 +67,9 @@ class ilist_node_base : public ilist_detail::node_base_prevnext<
EnableSentinelTracking>,
public ilist_detail::node_base_parent<ParentTy> {};
+// Specialization implemented in the core LLVM library.
+template class LLVM_ABI ilist_node_base<true, void>;
+
} // end namespace llvm
#endif // LLVM_ADT_ILIST_NODE_BASE_H
|
|
Can you make the PR title more descriptive? |
ilist_node_base template specialization
Thank you. Is this better? |
kazutakahirata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
|
Could you land this for me if there is no objection, please? I do not have the rights. |
@Steelskin Done. |
The core LLVM library implements a specialization for
ilist_node_base<true, void>, which is used by other components. This is needed to link properly when building LLVM as a library on Windows.This effort is tracked in #109483.