Skip to content

Conversation

@Steelskin
Copy link
Contributor

The core LLVM library implements a specialization for ilist_node_base<true, void>, which is used by other components. This is needed to link properly when building LLVM as a library on Windows.

This effort is tracked in #109483.

The core LLVM library implements a specialization for
`ilist_node_base<true, void>`, which is used by other components. This
is needed to link properly when building LLVM as a library on Windows.

This effort is tracked in llvm#109483.
@llvmbot
Copy link
Member

llvmbot commented Nov 14, 2025

@llvm/pr-subscribers-llvm-adt

Author: Fabrice de Gans (Steelskin)

Changes

The core LLVM library implements a specialization for ilist_node_base&lt;true, void&gt;, which is used by other components. This is needed to link properly when building LLVM as a library on Windows.

This effort is tracked in #109483.


Full diff: https://github.com/llvm/llvm-project/pull/168094.diff

1 Files Affected:

  • (modified) llvm/include/llvm/ADT/ilist_node_base.h (+3)
diff --git a/llvm/include/llvm/ADT/ilist_node_base.h b/llvm/include/llvm/ADT/ilist_node_base.h
index 49b197d3466d9..937e7d060e489 100644
--- a/llvm/include/llvm/ADT/ilist_node_base.h
+++ b/llvm/include/llvm/ADT/ilist_node_base.h
@@ -67,6 +67,9 @@ class ilist_node_base : public ilist_detail::node_base_prevnext<
                             EnableSentinelTracking>,
                         public ilist_detail::node_base_parent<ParentTy> {};
 
+// Specialization implemented in the core LLVM library.
+template class LLVM_ABI ilist_node_base<true, void>;
+
 } // end namespace llvm
 
 #endif // LLVM_ADT_ILIST_NODE_BASE_H

@kuhar
Copy link
Member

kuhar commented Nov 14, 2025

Can you make the PR title more descriptive?

@Steelskin Steelskin changed the title llvm: Add explicit template specialization llvm: Export ilist_node_base template specialization Nov 14, 2025
@Steelskin
Copy link
Contributor Author

Can you make the PR title more descriptive?

Thank you. Is this better?

@kuhar kuhar requested review from arsenm and nikic November 14, 2025 19:30
Copy link
Contributor

@kazutakahirata kazutakahirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Steelskin
Copy link
Contributor Author

Could you land this for me if there is no objection, please? I do not have the rights.

@kazutakahirata kazutakahirata merged commit 865c92b into llvm:main Nov 17, 2025
12 checks passed
@kazutakahirata
Copy link
Contributor

Could you land this for me if there is no objection, please? I do not have the rights.

@Steelskin Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants