[mlir][amdgpu] Add lowerings for ScaledExtPacked816 #168123
Merged
+379
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhar
reviewed
Nov 15, 2025
kuhar
reviewed
Nov 17, 2025
Member
kuhar
left a comment
kuhar
left a comment
There was a problem hiding this comment.
Can you update the PR title and make it start with an action verb?
amd-eochoalo
changed the title
🐧 Linux x64 Test Results
|
kuhar
approved these changes
Nov 17, 2025
krzysz00
reviewed
Nov 18, 2025
|
|
||
| std::optional<StringRef> maybeIntrinsic = | ||
| scaledExtPacked816ToIntrinsic(srcElemType, destElemType); | ||
| if (!maybeIntrinsic.has_value()) |
Contributor
There was a problem hiding this comment.
Post-commit review: this failure happens after IR has been created, which is a "pleane don't do that"
Can we swap this and the bitcaste above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.