Skip to content

Conversation

@clayborg
Copy link
Collaborator

Fixes a buildbot issue stemming from #167986

@llvmbot
Copy link
Member

llvmbot commented Nov 14, 2025

@llvm/pr-subscribers-debuginfo

Author: Greg Clayton (clayborg)

Changes

Fixes a buildbot issue stemming from #167986


Full diff: https://github.com/llvm/llvm-project/pull/168124.diff

1 Files Affected:

  • (modified) llvm/test/DebugInfo/dwarfdump-dwp-str-offsets-64.yaml (+1-2)
diff --git a/llvm/test/DebugInfo/dwarfdump-dwp-str-offsets-64.yaml b/llvm/test/DebugInfo/dwarfdump-dwp-str-offsets-64.yaml
index 3820ca7184d62..07f12cb84503d 100644
--- a/llvm/test/DebugInfo/dwarfdump-dwp-str-offsets-64.yaml
+++ b/llvm/test/DebugInfo/dwarfdump-dwp-str-offsets-64.yaml
@@ -20,8 +20,7 @@
 # CHECK:      0x0000001a:   DW_TAG_subprogram
 # CHECK-NEXT:                 DW_AT_low_pc    (indexed (00000000) address = <unresolved>)
 # CHECK-NEXT:                 DW_AT_high_pc   (0x0000000f)
-# CHECK-NEXT:                 DW_AT_frame_base        (DW_OP_reg6 RBP)
-# CHECK-NEXT:                 DW_AT_name      ("main")
+# CHECK:                      DW_AT_name      ("main")
 # CHECK-NEXT:                 DW_AT_decl_file (0x00)
 # CHECK-NEXT:                 DW_AT_decl_line (1)
 # CHECK-NEXT:                 DW_AT_type      (0x00000029 "int")

Copy link
Collaborator

@dyung dyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I am not really familiar with this area so would prefer if someone more familiar approved the change. But from what I see it should now pass on the failing bot.

@clayborg
Copy link
Collaborator Author

LGTM, although I am not really familiar with this area so would prefer if someone more familiar approved the change. But from what I see it should now pass on the failing bot.

The issue is that when you have a target compiled into your program (like x86_64 which is not compiled in on this buildbot) then the register name doesn't appear in the output and then the test fail happens. I removed the line that caused the issue and there are no other register names being printed. I am confident this will fix the issue.

@clayborg clayborg merged commit 4881512 into llvm:main Nov 14, 2025
9 of 12 checks passed
@clayborg clayborg deleted the buildbot-fix-for-167986 branch November 14, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants