Skip to content

[Clang] Export inline move constructors in dllexport-ed template instantiations on non-MSVC targets #168170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Clang] Export inline move constructors in dllexport-ed template instantiations on non-MSVC targets #168170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cef60af
pretest
kikairoya Nov 15, 2025
5dd04f3
[Clang] Export inline move constructors in dllexport-ed template inst…
kikairoya Nov 15, 2025
0291a34
update test
kikairoya Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clang/lib/Sema/SemaDeclCXX.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6627,6 +6627,7 @@ void Sema::checkClassLevelDLLAttribute(CXXRecordDecl *Class) {
auto *Ctor = dyn_cast<CXXConstructorDecl>(MD);
if ((MD->isMoveAssignmentOperator() ||
(Ctor && Ctor->isMoveConstructor())) &&
getLangOpts().isCompatibleWithMSVC(LangOptions::MSVC2010) &&
!getLangOpts().isCompatibleWithMSVC(LangOptions::MSVC2015))
continue;

Expand Down
1 change: 1 addition & 0 deletions clang/test/CodeGenCXX/dllexport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1131,5 +1131,6 @@ class __declspec(dllexport) ACE_Shared_Object {
class __declspec(dllexport) ACE_Service_Object : public ACE_Shared_Object {};
// Implicit move constructor declaration.
// MSVC2015-DAG: define weak_odr dso_local dllexport {{.+}}ACE_Service_Object@@Q{{.+}}@$$Q
// PS-DAG: define weak_odr dllexport void @_ZN18ACE_Service_ObjectC1EOS_
// The declarations should not be exported.
// MSVC2013-NOT: define weak_odr dso_local dllexport {{.+}}ACE_Service_Object@@Q{{.+}}@$$Q
2 changes: 2 additions & 0 deletions clang/test/CodeGenCXX/mingw-template-dllexport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@

template <class T>
class c {
c(c &&) noexcept {}
void f() {}
};

template class __declspec(dllexport) c<int>;

// CHECK: define {{.*}} dllexport {{.*}} @_ZN1cIiEC1EOS0_
// CHECK: define {{.*}} dllexport {{.*}} @_ZN1cIiE1fEv

extern template class __declspec(dllexport) c<char>;
Expand Down
Loading