Skip to content

[lldb][NFC] use llvm::erase_if to remove non matching types #168279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2025
Merged

[lldb][NFC] use llvm::erase_if to remove non matching types #168279

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3077718
[lldb][NFC] use llvm::erase_if to remove non matching types
da-viper Nov 16, 2025
81490fb
[lldb] add review changes
da-viper Nov 17, 2025
7e98454
[lldb] add review changes
da-viper Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 10 additions & 18 deletions lldb/source/Symbol/Symtab.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,15 +722,11 @@ Symtab::AppendSymbolIndexesWithNameAndType(ConstString symbol_name,
std::vector<uint32_t> &indexes) {
std::lock_guard<std::recursive_mutex> guard(m_mutex);

if (AppendSymbolIndexesWithName(symbol_name, indexes) > 0) {
std::vector<uint32_t>::iterator pos = indexes.begin();
while (pos != indexes.end()) {
if (symbol_type == eSymbolTypeAny ||
m_symbols[*pos].GetType() == symbol_type)
++pos;
else
pos = indexes.erase(pos);
}
if (AppendSymbolIndexesWithName(symbol_name, indexes) > 0 &&
symbol_type != eSymbolTypeAny) {
llvm::erase_if(indexes, [this, symbol_type](uint32_t index) {
return m_symbols[index].GetType() != symbol_type;
});
}
return indexes.size();
}
Expand All @@ -742,15 +738,11 @@ uint32_t Symtab::AppendSymbolIndexesWithNameAndType(
std::lock_guard<std::recursive_mutex> guard(m_mutex);

if (AppendSymbolIndexesWithName(symbol_name, symbol_debug_type,
symbol_visibility, indexes) > 0) {
std::vector<uint32_t>::iterator pos = indexes.begin();
while (pos != indexes.end()) {
if (symbol_type == eSymbolTypeAny ||
m_symbols[*pos].GetType() == symbol_type)
++pos;
else
pos = indexes.erase(pos);
}
symbol_visibility, indexes) > 0 &&
symbol_type != eSymbolTypeAny) {
llvm::erase_if(indexes, [this, symbol_type](uint32_t index) {
return m_symbols[index].GetType() != symbol_type;
});
}
return indexes.size();
}
Expand Down
Loading