[JITLink][MachO] Endianness fix for relocation bit-field handling. #168304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading r_pcrel, r_length, r_extern and r_type fields of any_relocation_info we need to take endianness into account. This is an alternative fix the issue described in for llvm#167902. This fix avoids external calls and further dependence on MachOObject file.
Contributor
Author
|
Nope, not needed: the "bitfields" here actually have the same layout in both endiannesses (due to https://github.com/apple-oss-distributions/cctools/blob/920a2b45080fb9badf31bf675f03b19973f0dd4f/include/mach-o/reloc.h#L140, I believe). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading r_pcrel, r_length, r_extern and r_type fields of any_relocation_info we need to take endianness into account.
This is an alternative fix the issue described in
for #167902. This fix avoids external calls and further dependence on MachOObject file.