Skip to content

[Flang] [OpenMP] Add support for spaces in between the name #168311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
+21 −0
Merged

[Flang] [OpenMP] Add support for spaces in between the name #168311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flang/lib/Parser/prescan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,6 +845,9 @@ bool Prescanner::NextToken(TokenSequence &tokens) {
if (InFixedFormSource()) {
SkipSpaces();
}
if (inFixedForm_ && (IsOpenMPDirective() && parenthesisNesting_ > 0)) {
SkipSpaces();
}
if ((*at_ == '\'' || *at_ == '"') &&
tokens.CharAt(tokens.SizeInChars() - 1) == '_') { // kind_"..."
QuotedCharacterLiteral(tokens, start);
Expand Down
3 changes: 3 additions & 0 deletions flang/lib/Parser/prescan.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,9 @@ class Prescanner {
bool InConditionalLine() const {
return InOpenMPConditionalLine() || InOpenACCOrCUDAConditionalLine();
}
bool IsOpenMPDirective() const {
return directiveSentinel_ && std::strcmp(directiveSentinel_, "$omp") == 0;
}
bool InFixedFormSource() const {
return inFixedForm_ && !inPreprocessorDirective_ && !InCompilerDirective();
}
Expand Down
15 changes: 15 additions & 0 deletions flang/test/Parser/OpenMP/name-with-space.f
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
! RUN: %flang_fc1 -fopenmp -fdebug-unparse-no-sema %s 2>&1 | FileCheck %s

program name_with_space
!CHECK: !$OMP THREADPRIVATE(/cc/, var1)
!$omp threadprivate(/c c/, var 1)

!CHECK: !$OMP PARALLEL PRIVATE(somevar,expr1,expr2) IF(expr2>expr1)
!$omp parallel private(some var, expr 1, ex pr2)
!$omp+ if (exp r2 > ex pr1)
!$omp critical (x_x)
print '(a)', 'Hello World'
!CHECK: !$OMP END CRITICAL(x_x)
!$omp end critical (x _x)
!$omp end parallel
end program name_with_space
Loading