-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[BPF] add allows-misaligned-mem-access target feature #168314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/21.x
Are you sure you want to change the base?
Conversation
This enables misaligned memory access when the feature is enabled
|
@yonghong-song I'd like to backport this change so that I can enable misalignment in the rust nightly compiler, thanks! |
|
I have no objection. But in the above, I see Not sure what is the problem. |
|
@clairechingching backports are typically done via the although I would say it's unlikely this will get backported so late in the release cycle given it's a feature. The next release is 21.1.7 on Dec 2nd, at this point in the release cycle the criteria is critical bug fixes as documented here https://llvm.org/docs/HowToReleaseLLVM.html#release-patch-rules. @tru is the release manager for 21.1.7, so ultimately it will be his decision. @tru wdyt? |
Error: Command failed due to missing milestone. |
|
oops, apologies I didn't mean to trigger the bot, please ignore that. |
|
@c-rhodes thanks for the clarification! This change is a feature that doesn’t alter the default behavior, it simply enables misalignment support for the BPF target when explicitly requested. We’d like to backport it so that the Rust compiler can take advantage of this functionality. I’ve tested locally to confirm that the feature is correctly enabled when used. Would appreciate it if you could accept the merge. |
/cherry-pick a4a645f
I'd like to backport this change to handle misaligned memory access in the BPF target which was merged in this original PR. Backporting it so I can enable this feature in the rust nightly compiler