Skip to content

[mlir][emitc] Refactor getEmittedExpression (NFC) #168361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
Merged

[mlir][emitc] Refactor getEmittedExpression (NFC) #168361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions mlir/lib/Target/Cpp/TranslateToCpp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,8 @@ struct CppEmitter {
return !fileId.empty() && file.getId() == fileId;
}

/// Get expression currently being emitted.
ExpressionOp getEmittedExpression() { return emittedExpression; }
/// Is expression currently being emitted.
bool isEmittingExpression() { return emittedExpression; }

/// Determine whether given value is part of the expression potentially being
/// emitted.
Expand Down Expand Up @@ -1717,7 +1717,7 @@ LogicalResult CppEmitter::emitGlobalVariable(GlobalOp op) {

LogicalResult CppEmitter::emitAssignPrefix(Operation &op) {
// If op is being emitted as part of an expression, bail out.
if (getEmittedExpression())
if (isEmittingExpression())
return success();

switch (op.getNumResults()) {
Expand Down Expand Up @@ -1799,7 +1799,7 @@ LogicalResult CppEmitter::emitOperation(Operation &op, bool trailingSemicolon) {
if (hasDeferredEmission(&op))
return success();

if (getEmittedExpression() ||
if (isEmittingExpression() ||
(isa<emitc::ExpressionOp>(op) &&
shouldBeInlined(cast<emitc::ExpressionOp>(op))))
return success();
Expand Down