Skip to content

[VectorUtils] Allow just poison in mask*All(Ones|Zero)OrUndef #168388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[VectorUtils] Allow just poison in mask*All(Ones|Zero)OrUndef #168388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions llvm/lib/Analysis/VectorUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,7 +1263,7 @@ bool llvm::maskIsAllZeroOrUndef(Value *Mask) {
auto *ConstMask = dyn_cast<Constant>(Mask);
if (!ConstMask)
return false;
if (ConstMask->isNullValue() || isa<UndefValue>(ConstMask))
if (match(ConstMask, m_CombineOr(m_Zero(), m_Undef())))
return true;
if (isa<ScalableVectorType>(ConstMask->getType()))
return false;
Expand All @@ -1272,7 +1272,7 @@ bool llvm::maskIsAllZeroOrUndef(Value *Mask) {
E = cast<FixedVectorType>(ConstMask->getType())->getNumElements();
I != E; ++I) {
if (auto *MaskElt = ConstMask->getAggregateElement(I))
if (MaskElt->isNullValue() || isa<UndefValue>(MaskElt))
if (match(MaskElt, m_CombineOr(m_Zero(), m_Undef())))
continue;
return false;
}
Expand All @@ -1289,7 +1289,7 @@ bool llvm::maskIsAllOneOrUndef(Value *Mask) {
auto *ConstMask = dyn_cast<Constant>(Mask);
if (!ConstMask)
return false;
if (ConstMask->isAllOnesValue() || isa<UndefValue>(ConstMask))
if (match(ConstMask, m_CombineOr(m_AllOnes(), m_Undef())))
Copy link
Collaborator

@RKSimon RKSimon Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isAllOnesValue can see through ConstantFP - can m_AllOnes()?

Copy link
Contributor Author

@artagnon artagnon Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! It can't; there are other issues with this patch including the fact that we're matching undef instead of just poison -- abandoning.

return true;
if (isa<ScalableVectorType>(ConstMask->getType()))
return false;
Expand All @@ -1298,7 +1298,7 @@ bool llvm::maskIsAllOneOrUndef(Value *Mask) {
E = cast<FixedVectorType>(ConstMask->getType())->getNumElements();
I != E; ++I) {
if (auto *MaskElt = ConstMask->getAggregateElement(I))
if (MaskElt->isAllOnesValue() || isa<UndefValue>(MaskElt))
if (match(MaskElt, m_CombineOr(m_AllOnes(), m_Undef())))
continue;
return false;
}
Expand All @@ -1315,7 +1315,7 @@ bool llvm::maskContainsAllOneOrUndef(Value *Mask) {
auto *ConstMask = dyn_cast<Constant>(Mask);
if (!ConstMask)
return false;
if (ConstMask->isAllOnesValue() || isa<UndefValue>(ConstMask))
if (match(ConstMask, m_CombineOr(m_AllOnes(), m_Undef())))
return true;
if (isa<ScalableVectorType>(ConstMask->getType()))
return false;
Expand All @@ -1324,7 +1324,7 @@ bool llvm::maskContainsAllOneOrUndef(Value *Mask) {
E = cast<FixedVectorType>(ConstMask->getType())->getNumElements();
I != E; ++I) {
if (auto *MaskElt = ConstMask->getAggregateElement(I))
if (MaskElt->isAllOnesValue() || isa<UndefValue>(MaskElt))
if (match(MaskElt, m_CombineOr(m_AllOnes(), m_Undef())))
return true;
}
return false;
Expand Down
Loading