Skip to content

[LLDB] Fix deadlock in module callback when running in parallel #168425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[LLDB] Fix deadlock in module callback when running in parallel #168425

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2d3ad3
Move lock guard before AddTargetInternal instead of holding the mutex…
Jlalond Nov 17, 2025
e672344
Move critical section into AddTargetInternal
Jlalond Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lldb/source/Target/TargetList.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ Status TargetList::CreateTarget(Debugger &debugger,
LoadDependentFiles load_dependent_files,
const OptionGroupPlatform *platform_options,
TargetSP &target_sp) {
std::lock_guard<std::recursive_mutex> guard(m_target_list_mutex);
// Create Target Internal does not modify any state
// directly and instead calls into methods which
// themselves are thread-safe. We need to do this so
// the locate module call back doesn't cause a re-entry
// dead lock when creating the target.
auto result = TargetList::CreateTargetInternal(
debugger, user_exe_path, triple_str, load_dependent_files,
platform_options, target_sp);
Expand All @@ -63,7 +67,11 @@ Status TargetList::CreateTarget(Debugger &debugger,
const ArchSpec &specified_arch,
LoadDependentFiles load_dependent_files,
PlatformSP &platform_sp, TargetSP &target_sp) {
std::lock_guard<std::recursive_mutex> guard(m_target_list_mutex);
// Create Target Internal does not modify any state
// directly and instead calls into methods which
// themselves are thread-safe. We need to do this so
// the locate module call back doesn't cause a re-entry
// dead lock when creating the target.
auto result = TargetList::CreateTargetInternal(
debugger, user_exe_path, specified_arch, load_dependent_files,
platform_sp, target_sp);
Expand Down Expand Up @@ -521,6 +529,7 @@ uint32_t TargetList::GetIndexOfTarget(lldb::TargetSP target_sp) const {
}

void TargetList::AddTargetInternal(TargetSP target_sp, bool do_select) {
std::lock_guard<std::recursive_mutex> guard(m_target_list_mutex);
lldbassert(!llvm::is_contained(m_target_list, target_sp) &&
"target already exists it the list");
UnregisterInProcessTarget(target_sp);
Expand Down
Loading