Skip to content

Improve error response message parsing for DAP evaluate requests. #168430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

Improve error response message parsing for DAP evaluate requests. #168430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions cross-project-tests/debuginfo-tests/dexter/dex/debugger/DAP.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,7 @@ def send_message(self, payload: dict) -> int:
self._proc.stdin.flush()
return self.seq

@staticmethod
def _handle_message(
message: dict, debugger_state: DAPDebuggerState, logger: Logger
):
Expand Down Expand Up @@ -419,6 +420,7 @@ def _handle_message(
request_seq = message["request_seq"]
debugger_state.set_response(request_seq, message)

@staticmethod
def _colorize_dap_message(message: dict) -> dict:
colorized_message = copy.deepcopy(message)
if colorized_message["type"] == "event":
Expand All @@ -432,6 +434,7 @@ def _colorize_dap_message(message: dict) -> dict:
colorized_message["command"] = f"<y>{colorized_message['command']}</>"
return colorized_message

@staticmethod
def _read_dap_output(
proc: subprocess.Popen,
debugger_state: DAPDebuggerState,
Expand All @@ -454,6 +457,7 @@ def _read_dap_output(
DAP._handle_message(message, debugger_state, logger)
buffer = rest[content_length:]

@staticmethod
def _read_dap_err(proc: subprocess.Popen, logger: Logger):
while True:
err: bytes = proc.stderr.readline()
Expand Down Expand Up @@ -930,10 +934,16 @@ def evaluate_expression(self, expression, frame_idx=0) -> ValueIR:
)
)
eval_response = self._await_response(eval_req_id)
result: str = ""
if not eval_response["success"]:
result: str = eval_response["message"]
if eval_response["body"].get("error", None):
result = eval_response["body"]["error"]["format"]
elif eval_response["message"]:
result = eval_response["message"]
else:
result = "<unable to evaluate expression>"
else:
result: str = eval_response["body"]["result"]
result = eval_response["body"]["result"]
type_str = eval_response["body"].get("type")

return self._evaluate_result_value(expression, result, type_str)
Loading