[libc]Github] Fix typo on build_type param #168453
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an extra underscore in build_type param in llvm#167583 patch. Fixing it in this PR.
Member
|
@llvm/pr-subscribers-github-workflow Author: Prabhu Rajasekaran (Prabhuk) ChangesThere is an extra underscore in build_type param in #167583 patch. Full diff: https://github.com/llvm/llvm-project/pull/168453.diff 1 Files Affected:
diff --git a/.github/workflows/libc-fullbuild-tests.yml b/.github/workflows/libc-fullbuild-tests.yml
index c5b7f606a115a..01fd895cce7e8 100644
--- a/.github/workflows/libc-fullbuild-tests.yml
+++ b/.github/workflows/libc-fullbuild-tests.yml
@@ -49,37 +49,37 @@ jobs:
target: x86_64-unknown-uefi-llvm
include_scudo: OFF
- os: ubuntu-24.04
- build__type: MinSizeRel
+ build_type: MinSizeRel
c_compiler: clang-22
cpp_compiler: clang++-22
target: armv6m-none-eabi
include_scudo: OFF
- os: ubuntu-24.04
- build__type: MinSizeRel
+ build_type: MinSizeRel
c_compiler: clang-22
cpp_compiler: clang++-22
target: armv7m-none-eabi
include_scudo: OFF
- os: ubuntu-24.04
- build__type: MinSizeRel
+ build_type: MinSizeRel
c_compiler: clang-22
cpp_compiler: clang++-22
target: armv7em-none-eabi
include_scudo: OFF
- os: ubuntu-24.04
- build__type: MinSizeRel
+ build_type: MinSizeRel
c_compiler: clang-22
cpp_compiler: clang++-22
target: armv8m.main-none-eabi
include_scudo: OFF
- os: ubuntu-24.04
- build__type: MinSizeRel
+ build_type: MinSizeRel
c_compiler: clang-22
cpp_compiler: clang++-22
target: armv8.1m.main-none-eabi
include_scudo: OFF
- os: ubuntu-24.04
- build__type: MinSizeRel
+ build_type: MinSizeRel
c_compiler: clang-22
cpp_compiler: clang++-22
target: riscv32-unknown-elf
|
boomanaiden154
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an extra underscore in build_type param in #167583 patch.
Fixing it in this PR.