[CI] Gracefully Fail when Job Completion Timestamp is None #168457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seem to be cases where the workflow status is completed but the jobs have not completed. We need to gracefully handle these changes to avoid a crash loop in the metrics container.
Member
|
@llvm/pr-subscribers-infrastructure Author: Aiden Grossman (boomanaiden154) ChangesThere seem to be cases where the workflow status is completed but the jobs have not completed. We need to gracefully handle these changes to avoid a crash loop in the metrics container. Full diff: https://github.com/llvm/llvm-project/pull/168457.diff 1 Files Affected:
diff --git a/.ci/metrics/metrics.py b/.ci/metrics/metrics.py
index a6d6edbd547e7..4e665adaca3ae 100644
--- a/.ci/metrics/metrics.py
+++ b/.ci/metrics/metrics.py
@@ -370,6 +370,13 @@ def github_get_metrics(
started_at = job.started_at
completed_at = job.completed_at
+ if completed_at is None:
+ logging.info(
+ "Workflow {} is marked completed but has a job without a "
+ "completion timestamp."
+ )
+ continue
+
# GitHub API can return results where the started_at is slightly
# later then the created_at (or completed earlier than started).
# This would cause a -23h59mn delta, which will show up as +24h
|
cmtice
reviewed
Nov 17, 2025
.ci/metrics/metrics.py
Outdated
|
|
||
| if completed_at is None: | ||
| logging.info( | ||
| "Workflow {} is marked completed but has a job without a " |
Contributor
There was a problem hiding this comment.
What are the curly braces for?
Contributor
Author
There was a problem hiding this comment.
Was meant to point to an ID through an fstring. Fixed now.
🐧 Linux x64 Test Results
|
cmtice
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to be cases where the workflow status is completed but the jobs have not completed. We need to gracefully handle these changes to avoid a crash loop in the metrics container.