Skip to content

[LLDB] Add log channel for InstrumentationRuntime plugins #168508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
+9 −2
Merged

[LLDB] Add log channel for InstrumentationRuntime plugins #168508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lldb/include/lldb/Utility/LLDBLog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ enum class LLDBLog : Log::MaskType {
OnDemand = Log::ChannelFlag<31>,
Source = Log::ChannelFlag<32>,
Disassembler = Log::ChannelFlag<33>,
LLVM_MARK_AS_BITMASK_ENUM(Disassembler),
InstrumentationRuntime = Log::ChannelFlag<34>,
LLVM_MARK_AS_BITMASK_ENUM(InstrumentationRuntime),
};

LLVM_ENABLE_BITMASK_ENUMS_IN_NAMESPACE();
Expand Down
5 changes: 4 additions & 1 deletion lldb/source/Plugins/InstrumentationRuntime/Utility/ReportRetriever.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,11 @@ bool ReportRetriever::NotifyBreakpointHit(ProcessSP process_sp,
return false;

StructuredData::ObjectSP report = RetrieveReportData(process_sp);
if (!report || report->GetType() != lldb::eStructuredDataTypeDictionary)
if (!report || report->GetType() != lldb::eStructuredDataTypeDictionary) {
LLDB_LOGF(GetLog(LLDBLog::InstrumentationRuntime),
"ReportRetriever::RetrieveReportData() failed");
return false;
}

std::string description = FormatDescription(report);

Expand Down
3 changes: 3 additions & 0 deletions lldb/source/Utility/LLDBLog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ static constexpr Log::Category g_categories[] = {
{{"disassembler"},
{"log disassembler related activities"},
LLDBLog::Disassembler},
{{"instrumentation-runtime"},
{"log instrumentation runtime plugin related activities"},
LLDBLog::InstrumentationRuntime},
};

static Log::Channel g_log_channel(g_categories,
Expand Down
Loading