Skip to content

[MLIR][ODS] Fully qualify namespace for mlir::Attribute in ODS generated code #168536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
+3 −3
Merged

[MLIR][ODS] Fully qualify namespace for mlir::Attribute in ODS generated code #168536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mlir/include/mlir/IR/Properties.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ class ArrayProp<Property elem = Property<>, string newSummary = ""> :
return $_diag() << "expected array attribute";
for (::mlir::Attribute elemAttr : arrayAttr) {
}] # _makePropStorage<elem, "elemVal">.ret # [{
auto elemRes = [&](Attribute propAttr, }] # elem.storageType # [{& propStorage) -> ::mlir::LogicalResult {
auto elemRes = [&](::mlir::Attribute propAttr, }] # elem.storageType # [{& propStorage) -> ::mlir::LogicalResult {
}] # !subst("$_attr", "propAttr",
!subst("$_storage", "propStorage", elem.convertFromAttribute)) # [{
}(elemAttr, elemVal);
Expand All @@ -480,7 +480,7 @@ class ArrayProp<Property elem = Property<>, string newSummary = ""> :
}];

let convertToAttribute = [{
SmallVector<Attribute> elems;
SmallVector<::mlir::Attribute> elems;
for (const auto& elemVal : $_storage) {
auto elemAttr = [&](const }] # elem.storageType #[{& propStorage) -> ::mlir::Attribute {
}] # !subst("$_storage", "propStorage", elem.convertToAttribute) # [{
Expand Down Expand Up @@ -647,7 +647,7 @@ class OptionalProp<Property p, bit canDelegateParsing = 1>
}
::mlir::Attribute presentAttr = arrayAttr[0];
}] # _makePropStorage<p, "presentVal">.ret # [{
auto presentRes = [&](Attribute propAttr, }] # p.storageType # [{& propStorage) -> ::mlir::LogicalResult {
auto presentRes = [&](::mlir::Attribute propAttr, }] # p.storageType # [{& propStorage) -> ::mlir::LogicalResult {
}] # !subst("$_storage", "propStorage",
!subst("$_attr", "propAttr", p.convertFromAttribute)) # [{
}(presentAttr, presentVal);
Expand Down
Loading