Skip to content

Conversation

@rupprecht
Copy link
Collaborator

@rupprecht rupprecht commented Nov 18, 2025

Switches to the config added in #164891

Fixes #55924

@rupprecht rupprecht added the skip-precommit-approval PR for CI feedback, not intended for review label Nov 18, 2025
@rupprecht rupprecht removed the skip-precommit-approval PR for CI feedback, not intended for review label Nov 18, 2025
@rupprecht rupprecht marked this pull request as ready for review November 18, 2025 17:13
@llvmbot llvmbot added the bazel "Peripheral" support tier build system: utils/bazel label Nov 18, 2025
@rupprecht
Copy link
Collaborator Author

I don't know what kind of testing we need to do for this -- besides our own CI, which passes. How much time do people need to test this out in their own repos? Is it easier to just land this now and revert later if downstream users discover issues? Unless others have opinions, I'll plan on giving this a week.

@keith
Copy link
Member

keith commented Nov 18, 2025

This is harmless since downstream repos shouldn't inherit this bazelrc setting. The last PR is the one that would affect folks

@rupprecht
Copy link
Collaborator Author

This is harmless since downstream repos shouldn't inherit this bazelrc setting. The last PR is the one that would affect folks

Ah, didn't realize that :)

In that case, I guess I might as well land this now?

The next step after this would be to delete the WORKSPACE file. Do you know what downstream things, if anything, we would need to wait for before deleting that?

@keith
Copy link
Member

keith commented Nov 18, 2025

That should be safe too. Next breaking thing would be deleting the deps bzl file

@rupprecht rupprecht merged commit a4456a5 into llvm:main Nov 19, 2025
14 of 15 checks passed
@rupprecht rupprecht deleted the bzl-migrate-bzlmod-switch branch November 19, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bazel "Peripheral" support tier build system: utils/bazel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bazel] Add support for bzlmod module system

3 participants