Skip to content

[flang] "Almost NFC" changes to fir::runtime::genCharCompare() #168563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2025
Merged

[flang] "Almost NFC" changes to fir::runtime::genCharCompare() #168563

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a232909
[flang] Optimization for length 1 char 1 compare in lowering
eugeneepshteyn Nov 16, 2025
aea5e02
Merge branch 'char-compare-lowering' into nfc-gen-char-compare
eugeneepshteyn Nov 18, 2025
5d0ef79
clang-format
eugeneepshteyn Nov 18, 2025
69c50fd
Merge branch 'main' into nfc-gen-char-compare
eugeneepshteyn Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions flang/lib/Optimizer/Builder/Runtime/Character.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,27 +94,34 @@ fir::runtime::genCharCompare(fir::FirOpBuilder &builder, mlir::Location loc,
mlir::arith::CmpIPredicate cmp,
mlir::Value lhsBuff, mlir::Value lhsLen,
mlir::Value rhsBuff, mlir::Value rhsLen) {
mlir::func::FuncOp beginFunc;
switch (discoverKind(lhsBuff.getType())) {
int lhsKind = discoverKind(lhsBuff.getType());
int rhsKind = discoverKind(rhsBuff.getType());
if (lhsKind != rhsKind) {
fir::emitFatalError(loc, "runtime does not support comparison of different "
"CHARACTER kind values");
}
mlir::func::FuncOp func;
switch (lhsKind) {
case 1:
beginFunc = fir::runtime::getRuntimeFunc<mkRTKey(CharacterCompareScalar1)>(
func = fir::runtime::getRuntimeFunc<mkRTKey(CharacterCompareScalar1)>(
loc, builder);
break;
case 2:
beginFunc = fir::runtime::getRuntimeFunc<mkRTKey(CharacterCompareScalar2)>(
func = fir::runtime::getRuntimeFunc<mkRTKey(CharacterCompareScalar2)>(
loc, builder);
break;
case 4:
beginFunc = fir::runtime::getRuntimeFunc<mkRTKey(CharacterCompareScalar4)>(
func = fir::runtime::getRuntimeFunc<mkRTKey(CharacterCompareScalar4)>(
loc, builder);
break;
default:
llvm_unreachable("runtime does not support CHARACTER KIND");
fir::emitFatalError(
loc, "unsupported CHARACTER kind value. Runtime expects 1, 2, or 4.");
}
auto fTy = beginFunc.getFunctionType();
auto fTy = func.getFunctionType();
auto args = fir::runtime::createArguments(builder, loc, fTy, lhsBuff, rhsBuff,
lhsLen, rhsLen);
auto tri = fir::CallOp::create(builder, loc, beginFunc, args).getResult(0);
auto tri = fir::CallOp::create(builder, loc, func, args).getResult(0);
auto zero = builder.createIntegerConstant(loc, tri.getType(), 0);
return mlir::arith::CmpIOp::create(builder, loc, cmp, tri, zero);
}
Expand Down