Skip to content

[tosa] : Enhance EqualizeRanks to handle dynamic dimensions. #168564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2025
Merged

[tosa] : Enhance EqualizeRanks to handle dynamic dimensions. #168564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54c3b3b
[tosa] : Enhance EqualizeRanks to handle dynamic dimensions.
sahas3 Nov 18, 2025
8820877
Update function name to be more readable.
sahas3 Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion mlir/lib/Dialect/Tosa/Utils/ConversionUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ namespace {
// If lower=[a], higher=[a, a], [a] reshaped into [1, a].
// If lower=[a], target=[a, b, a], [a] reshaped into [1, 1, a].
// If lower=[], target=[a, b, c], [] reshaped into [1, 1, 1].
// If lower=[c], higher=[?, ?, c], [c] reshaped into [1, 1, c].
// If lower=[?], higher=[?, ?, ?], [?] reshaped into [1, 1, ?].
LogicalResult
computeReshapeOutput(ArrayRef<int64_t> higherRankShape,
ArrayRef<int64_t> lowerRankShape,
Expand All @@ -87,7 +89,12 @@ computeReshapeOutput(ArrayRef<int64_t> higherRankShape,
higherRankDim = higherRankShape[i + rankDiff];
lowerRankDim = lowerRankShape[i];

if (lowerRankDim != 1 && higherRankDim != 1 &&
auto isStaticDimAndNotEqualToOne = [](int64_t dim) {
return dim != 1 && dim != ShapedType::kDynamic;
};

if (isStaticDimAndNotEqualToOne(lowerRankDim) &&
isStaticDimAndNotEqualToOne(higherRankDim) &&
lowerRankDim != higherRankDim)
return failure();

Expand Down