[compiler-rt] [libFuzzer] Fix merge-posix test (again) #168639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
168137 fixed an issue where this test failed because there was not a sufficiently large file in the corpus. However, there is still another issue: the MERGE-INNER process can try to write a control file that is above the 1024B limit. This also fails the test, since the test expects the MERGE-OUTER process to be the one to get the SIGXFSZ. To get around this, increase the ulimit to 4K and the largest testcase to 4K (plus 6B). We will assume that on every test platform, the control file will be less than 4K. rdar://164738648
Member
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Andrew Haberlandt (ndrewh) Changes#168137 fixed an issue where this test failed because there was not a sufficiently large file in the corpus. However, there is still another issue: the MERGE-INNER process can try to write a control file that is above the 1024B limit. This also fails the test, since the test expects the MERGE-OUTER process to be the one to get the SIGXFSZ. To get around this, increase the ulimit to 4K and the largest testcase to 4K (plus 6B). We will assume that on every test platform, the control file will be less than 4K. rdar://164738648 Full diff: https://github.com/llvm/llvm-project/pull/168639.diff 1 Files Affected:
diff --git a/compiler-rt/test/fuzzer/merge-posix.test b/compiler-rt/test/fuzzer/merge-posix.test
index 5e342142216f8..6e37651e6fd29 100644
--- a/compiler-rt/test/fuzzer/merge-posix.test
+++ b/compiler-rt/test/fuzzer/merge-posix.test
@@ -14,10 +14,10 @@ RUN: echo ....U. > %tmp/T2/2
RUN: echo ...Z.. > %tmp/T2/3
RUN: echo ...Z.. > %tmp/T2/4
RUN: echo ....E. > %tmp/T2/5
-RUN: %python -c "print('.....R' + 'X' * 1024, end='')" > %tmp/T2/6
+RUN: %python -c "print('.....R' + 'X' * 4096, end='')" > %tmp/T2/6
# Check that we can report an error if file size exceeded
-RUN: (ulimit -f 1; not %run %t-FullCoverageSetTest -merge=1 %tmp/T1 %tmp/T2 2>&1 | FileCheck %s --check-prefix=SIGXFSZ)
+RUN: (ulimit -f 4; not %run %t-FullCoverageSetTest -merge=1 %tmp/T1 %tmp/T2 2>&1 | FileCheck %s --check-prefix=SIGXFSZ)
SIGXFSZ: ERROR: libFuzzer: file size exceeded
# Check that we honor TMPDIR
|
🐧 Linux x64 Test Results
|
DanBlackwell
approved these changes
Nov 19, 2025
Contributor
DanBlackwell
left a comment
DanBlackwell
left a comment
There was a problem hiding this comment.
Thanks for investigating
ndrewh
added a commit
to ndrewh/llvm-project
that referenced
this pull request
Nov 21, 2025
(cherry picked from commit c6775e2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#168137 fixed an issue where this test failed because there was not a sufficiently large file in the corpus.
However, there is still another issue: the MERGE-INNER process can try to write a control file that is above the 1024B limit. This also fails the test, since the test expects the MERGE-OUTER process to be the one to get the SIGXFSZ.
To get around this, increase the ulimit to 4K and the largest testcase to 4K (plus 6B). We will assume that on every test platform, the control file will be less than 4K.
rdar://164738648