[llvm] Construct iterator_range with the conversion constructor (NFC)

[kazutakahirata]

This patch simplifies iterator_range construction with the conversion
constructor.

[llvmbot]

@llvm/pr-subscribers-vectorizers
@llvm/pr-subscribers-llvm-binary-utilities

@llvm/pr-subscribers-debuginfo

Author: Kazu Hirata (kazutakahirata)

Changes

This patch simplifies iterator_range construction with the conversion
constructor.

---

Full diff: https://github.com/llvm/llvm-project/pull/168674.diff

4 Files Affected:

• (modified) llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h (+2-2)
• (modified) llvm/include/llvm/Object/OffloadBinary.h (+1-3)
• (modified) llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h (+2-6)
• (modified) llvm/lib/Object/RecordStreamer.cpp (+1-1)

diff --git a/llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h b/llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h
index d0187e885a518..f95b78ec6babd 100644
--- a/llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h
+++ b/llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h
@@ -195,7 +195,7 @@ class LLVM_ABI DWARFContext : public DIContext {
   /// Get all normal compile/type units in this context.
   unit_iterator_range normal_units() {
     DWARFUnitVector &NormalUnits = State->getNormalUnits();
-    return unit_iterator_range(NormalUnits.begin(), NormalUnits.end());
+    return NormalUnits;
   }
 
   /// Get units from .debug_info..dwo in the DWO context.
@@ -231,7 +231,7 @@ class LLVM_ABI DWARFContext : public DIContext {
   /// Get all units in the DWO context.
   unit_iterator_range dwo_units() {
     DWARFUnitVector &DWOUnits = State->getDWOUnits();
-    return unit_iterator_range(DWOUnits.begin(), DWOUnits.end());
+    return DWOUnits;
   }
 
   /// Get the number of compile units in this context.
diff --git a/llvm/include/llvm/Object/OffloadBinary.h b/llvm/include/llvm/Object/OffloadBinary.h
index ac2dbf60e2aec..f3847c1624977 100644
--- a/llvm/include/llvm/Object/OffloadBinary.h
+++ b/llvm/include/llvm/Object/OffloadBinary.h
@@ -100,9 +100,7 @@ class OffloadBinary : public Binary {
   }
 
   // Iterator over all the key and value pairs in the binary.
-  string_iterator_range strings() const {
-    return string_iterator_range(StringData.begin(), StringData.end());
-  }
+  string_iterator_range strings() const { return StringData; }
 
   StringRef getString(StringRef Key) const { return StringData.lookup(Key); }
 
diff --git a/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h b/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h
index 821382b0b12d0..8beb6a49c693d 100644
--- a/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h
+++ b/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h
@@ -314,12 +314,8 @@ class SeedCollector {
                          bool AllowDiffTypes = false);
   LLVM_ABI ~SeedCollector();
 
-  iterator_range<SeedContainer::iterator> getStoreSeeds() {
-    return {StoreSeeds.begin(), StoreSeeds.end()};
-  }
-  iterator_range<SeedContainer::iterator> getLoadSeeds() {
-    return {LoadSeeds.begin(), LoadSeeds.end()};
-  }
+  iterator_range<SeedContainer::iterator> getStoreSeeds() { return StoreSeeds; }
+  iterator_range<SeedContainer::iterator> getLoadSeeds() { return LoadSeeds; }
 #ifndef NDEBUG
   void print(raw_ostream &OS) const;
   LLVM_DUMP_METHOD void dump() const;
diff --git a/llvm/lib/Object/RecordStreamer.cpp b/llvm/lib/Object/RecordStreamer.cpp
index 891016cf74755..6e8d0c477803e 100644
--- a/llvm/lib/Object/RecordStreamer.cpp
+++ b/llvm/lib/Object/RecordStreamer.cpp
@@ -126,7 +126,7 @@ void RecordStreamer::emitELFSymverDirective(const MCSymbol *OriginalSym,
 
 iterator_range<RecordStreamer::const_symver_iterator>
 RecordStreamer::symverAliases() {
-  return {SymverAliasMap.begin(), SymverAliasMap.end()};
+  return SymverAliasMap;
 }
 
 void RecordStreamer::flushSymverDirectives() {

[github-actions]

🐧 Linux x64 Test Results

• 186358 tests passed
• 4855 tests skipped