[lldb][windows] add color to the Python.dll not found error #168718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-zablit
requested review from
adrian-prantl and
compnerd
and removed request for
JDevlieghere
Member
|
@llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) ChangesMake the ExampleBefore<img width="782" height="431" alt="Screenshot 2025-11-19 at 15 50 22" src="https://github.com/user-attachments/assets/93960c50-cbf2-41f7-aba3-2f2a8af916cc" /> After<img width="780" height="430" alt="Screenshot 2025-11-19 at 15 54 28" src="https://github.com/user-attachments/assets/f7f4954b-0ce3-4a4b-b9af-5af876032573" /> Full diff: https://github.com/llvm/llvm-project/pull/168718.diff 1 Files Affected:
diff --git a/lldb/tools/driver/Driver.cpp b/lldb/tools/driver/Driver.cpp
index bebf1a70d50e9..0b77e0a4929a7 100644
--- a/lldb/tools/driver/Driver.cpp
+++ b/lldb/tools/driver/Driver.cpp
@@ -508,12 +508,12 @@ void SetupPythonRuntimeLibrary() {
if (AddPythonDLLToSearchPath() && IsPythonDLLInPath())
return;
#endif
- llvm::errs() << "error: unable to find '"
- << LLDB_PYTHON_RUNTIME_LIBRARY_FILENAME << "'.\n";
+ WithColor::error() << "unable to find '"
+ << LLDB_PYTHON_RUNTIME_LIBRARY_FILENAME << "'.\n";
return;
#elif defined(LLDB_PYTHON_DLL_RELATIVE_PATH)
if (!AddPythonDLLToSearchPath())
- llvm::errs() << "error: unable to find the Python runtime library.\n";
+ WithColor::error() << "unable to find the Python runtime library.\n";
#endif
}
#endif
|
🐧 Linux x64 Test Results
|
compnerd
approved these changes
Nov 19, 2025
charles-zablit
added a commit
to charles-zablit/llvm-project
that referenced
this pull request
Nov 19, 2025
) Make the `Python.dll not found` error message stand out more by using the `llvm::WithColor::error()` method. --- ### Example #### Before <img width="782" height="431" alt="Screenshot 2025-11-19 at 15 50 22" src="https://github.com/user-attachments/assets/93960c50-cbf2-41f7-aba3-2f2a8af916cc" /> #### After <img width="780" height="430" alt="Screenshot 2025-11-19 at 15 54 28" src="https://github.com/user-attachments/assets/f7f4954b-0ce3-4a4b-b9af-5af876032573" /> rdar://165047059
charles-zablit
added a commit
to charles-zablit/llvm-project
that referenced
this pull request
Nov 19, 2025
) Make the `Python.dll not found` error message stand out more by using the `llvm::WithColor::error()` method. --- ### Example #### Before <img width="782" height="431" alt="Screenshot 2025-11-19 at 15 50 22" src="https://github.com/user-attachments/assets/93960c50-cbf2-41f7-aba3-2f2a8af916cc" /> #### After <img width="780" height="430" alt="Screenshot 2025-11-19 at 15 54 28" src="https://github.com/user-attachments/assets/f7f4954b-0ce3-4a4b-b9af-5af876032573" /> rdar://165047059
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
Python.dll not founderror message stand out more by using thellvm::WithColor::error()method.Example
Before
After
rdar://165047059