Skip to content

Conversation

@rupprecht
Copy link
Collaborator

@rupprecht rupprecht commented Nov 19, 2025

vulkan_sdk_setup is the name of the method that configures it, but the repo itself has the name vulkan_sdk

This was caught by enabling the bzlmod flag for CI. The GH action runs blaze test @llvm-project/... but the target is tagged manual, so it's excluded. The buildkite CI runs bazel query | xargs bazel test which will include manual targets.

@rupprecht rupprecht added the skip-precommit-approval PR for CI feedback, not intended for review label Nov 19, 2025
@rupprecht rupprecht marked this pull request as ready for review November 19, 2025 19:50
@llvmbot llvmbot added the bazel "Peripheral" support tier build system: utils/bazel label Nov 19, 2025
@rupprecht rupprecht merged commit afcb953 into llvm:main Nov 19, 2025
15 of 16 checks passed
@rupprecht rupprecht deleted the bzl-vulkan-sdk branch November 19, 2025 19:57
aadeshps-mcw pushed a commit to aadeshps-mcw/llvm-project that referenced this pull request Nov 26, 2025
vulkan_sdk_setup is the name of the method that configures it, but the
repo itself has the name vulkan_sdk

This was caught by enabling the bzlmod flag for CI. The GH action runs
`blaze test @llvm-project/...` but the target is tagged manual, so it's
excluded. The buildkite CI runs `bazel query | xargs bazel test` which
will include manual targets.
Priyanshu3820 pushed a commit to Priyanshu3820/llvm-project that referenced this pull request Nov 26, 2025
vulkan_sdk_setup is the name of the method that configures it, but the
repo itself has the name vulkan_sdk

This was caught by enabling the bzlmod flag for CI. The GH action runs
`blaze test @llvm-project/...` but the target is tagged manual, so it's
excluded. The buildkite CI runs `bazel query | xargs bazel test` which
will include manual targets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bazel "Peripheral" support tier build system: utils/bazel skip-precommit-approval PR for CI feedback, not intended for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants