[ASAN] Disable broken __SANITIZER_DISABLE_CONTAINER_OVERFLOW__ tests on iOS/Android #168821
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
compiler-rt
compiler-rt:asan
Member
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Andrew Haberlandt (ndrewh) ChangesThe tests added by #163468 appear to be broken on iOS and android. Full diff: https://github.com/llvm/llvm-project/pull/168821.diff 2 Files Affected:
diff --git a/compiler-rt/test/asan/TestCases/disable_container_overflow_checks.cpp b/compiler-rt/test/asan/TestCases/disable_container_overflow_checks.cpp
index 680eb252411da..8b1661b990f93 100644
--- a/compiler-rt/test/asan/TestCases/disable_container_overflow_checks.cpp
+++ b/compiler-rt/test/asan/TestCases/disable_container_overflow_checks.cpp
@@ -12,6 +12,7 @@
// RUN: %clangxx_asan -D__SANITIZER_DISABLE_CONTAINER_OVERFLOW__ -O %s -o %t-no-overflow
// RUN: %run %t-no-overflow 2>&1 | FileCheck --check-prefix=CHECK-NOCRASH %s
//
+// UNSUPPORTED: ios, android
#include <assert.h>
#include <stdio.h>
diff --git a/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp b/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp
index 07c143609e94d..2ab9ba8083b73 100644
--- a/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp
+++ b/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp
@@ -19,6 +19,8 @@
// RUN: %clangxx_asan -D__SANITIZER_DISABLE_CONTAINER_OVERFLOW__ %s -c -o %t-main.o
// RUN: %clangxx_asan -D__SANITIZER_DISABLE_CONTAINER_OVERFLOW__ -o %t %t-main.o %t-object.o %libdl
// RUN: %run %t 2>&1 | FileCheck --check-prefix=CHECK-NO-CONTAINER-OVERFLOW %s
+//
+// UNSUPPORTED: ios, android
#include <assert.h>
#include <sanitizer/common_interface_defs.h>
|
This was referenced Nov 20, 2025
🐧 Linux x64 Test Results
|
Contributor
|
These also fail on macOS: https://green.lab.llvm.org/job/llvm.org/job/clang-stage1-cmake-RA-expensive/5755/testReport/. I believe they need to be marked XFAIL for all while awaiting the corresponding change to be made to libcxx. |
DanBlackwell
requested changes
Nov 20, 2025
Contributor
DanBlackwell
left a comment
DanBlackwell
left a comment
There was a problem hiding this comment.
I think these should be XFAIL: * while waiting for libcxx to start including the header file rather than forward declaring. XFAIL gives us insight to when the change lands (as we'll start receiving XPASSes), so I'd prefer over unsupported if possible.
| // RUN: %clangxx_asan -D__SANITIZER_DISABLE_CONTAINER_OVERFLOW__ -O %s -o %t-no-overflow | ||
| // RUN: %run %t-no-overflow 2>&1 | FileCheck --check-prefix=CHECK-NOCRASH %s | ||
| // | ||
| // UNSUPPORTED: ios, android |
Contributor
There was a problem hiding this comment.
Suggested change
| // UNSUPPORTED: ios, android | |
| // XFAIL: * |
| // RUN: %clangxx_asan -D__SANITIZER_DISABLE_CONTAINER_OVERFLOW__ -o %t %t-main.o %t-object.o %libdl | ||
| // RUN: %run %t 2>&1 | FileCheck --check-prefix=CHECK-NO-CONTAINER-OVERFLOW %s | ||
| // | ||
| // UNSUPPORTED: ios, android |
Contributor
There was a problem hiding this comment.
Suggested change
| // UNSUPPORTED: ios, android | |
| // XFAIL: * |
DanBlackwell
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests added by #163468 appear to be broken on iOS (sim) and android. I have no idea if this works on iOS (devices) or not, so I'm just marking UNSUPPORTED rather than XFAIL.
Android: https://lab.llvm.org/buildbot/#/builders/186/builds/14106