Skip to content

Conversation

@mstorsjo
Copy link
Member

Don't specifically target windows-msvc - the same goes for any windows target; mingw doesn't have dlfcn.h either.

Don't specifically target windows-msvc - the same goes for any
windows target; mingw doesn't have dlfcn.h either.
@mstorsjo
Copy link
Member Author

CC @padriff

@llvmbot
Copy link
Member

llvmbot commented Nov 20, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Martin Storsjö (mstorsjo)

Changes

Don't specifically target windows-msvc - the same goes for any windows target; mingw doesn't have dlfcn.h either.


Full diff: https://github.com/llvm/llvm-project/pull/168858.diff

1 Files Affected:

  • (modified) compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp (+1-1)
diff --git a/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp b/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp
index 07c143609e94d..cb771f5c95639 100644
--- a/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp
+++ b/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp
@@ -1,6 +1,6 @@
 // Test to demonstrate compile-time disabling of container-overflow checks
 // in order to handle uninstrumented libraries
-// UNSUPPORTED: target={{.*windows-msvc.*}}
+// UNSUPPORTED: target={{.*windows-.*}}
 
 // Mimic a closed-source library compiled without ASan
 // RUN: %clangxx_asan -fno-sanitize=address -DSHARED_LIB %s %fPIC -shared -o %t-so.so

@github-actions
Copy link

🐧 Linux x64 Test Results

  • 5824 tests passed
  • 1319 tests skipped

@DanBlackwell
Copy link
Contributor

These have now been marked unsupported for all platforms here: https://github.com/llvm/llvm-project/pull/168821/files.

@mstorsjo
Copy link
Member Author

These have now been marked unsupported for all platforms here: https://github.com/llvm/llvm-project/pull/168821/files.

Thanks! But as long as the test is still in place, I'll go ahead and merge this, so the issue doesn't reappear if the UNSUPPORTED: true is removed again later.

@mstorsjo mstorsjo merged commit 04acac2 into llvm:main Nov 20, 2025
14 checks passed
@mstorsjo mstorsjo deleted the compiler-rt-test-unsupp-regex branch November 20, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants