Skip to content

Fix build breakage when using modules #168883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2025
Merged

Fix build breakage when using modules #168883

merged 1 commit into from
Nov 20, 2025

Conversation

@redstar
Copy link
Member

@redstar redstar commented Nov 20, 2025

Commit c9f5734 removed the file TargetLibraryInfo.def but did not remove it from the module map.

@redstar
Fix build breakage when using modules
683de3b 
Commit c9f5734 removed the file TargetLibraryInfo.def but did not remove it from the module map.
@redstar redstar requested a review from juliannagele November 20, 2025 15:05
@redstar redstar self-assigned this Nov 20, 2025
@redstar redstar mentioned this pull request Nov 20, 2025
Merged
juliannagele
juliannagele approved these changes Nov 20, 2025
View reviewed changes
Copy link
Member

@juliannagele juliannagele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@redstar redstar merged commit 0c085c4 into main Nov 20, 2025
10 of 11 checks passed
@redstar redstar deleted the users/redstar/modulemapupdate branch November 20, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliannagele juliannagele juliannagele approved these changes

Assignees

@redstar redstar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@redstar @juliannagele