Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions llvm/include/llvm/Analysis/TargetTransformInfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include "llvm/ADT/APInt.h"
#include "llvm/ADT/ArrayRef.h"
#include "llvm/ADT/BitmaskEnum.h"
#include "llvm/ADT/Uniformity.h"
#include "llvm/Analysis/IVDescriptors.h"
#include "llvm/Analysis/InterestingMemoryOperand.h"
#include "llvm/IR/FMF.h"
Expand Down Expand Up @@ -468,6 +469,15 @@ class TargetTransformInfo {
// even taking non-uniform arguments
LLVM_ABI bool isAlwaysUniform(const Value *V) const;

/// Get target-specific uniformity information for an instruction.
/// This allows targets to provide more fine-grained control over
/// uniformity analysis by specifying whether specific instructions
/// should always or never be considered uniform, or require custom
/// operand-based analysis.
/// \param V The value to query for uniformity information.
/// \return InstructionUniformity.
LLVM_ABI InstructionUniformity getInstructionUniformity(const Value *V) const;

/// Query the target whether the specified address space cast from FromAS to
/// ToAS is valid.
LLVM_ABI bool isValidAddrSpaceCast(unsigned FromAS, unsigned ToAS) const;
Expand Down
4 changes: 4 additions & 0 deletions llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,10 @@ class TargetTransformInfoImplBase {

virtual bool isAlwaysUniform(const Value *V) const { return false; }

virtual InstructionUniformity getInstructionUniformity(const Value *V) const {
return InstructionUniformity::Default;
}

virtual bool isValidAddrSpaceCast(unsigned FromAS, unsigned ToAS) const {
return false;
}
Expand Down
5 changes: 5 additions & 0 deletions llvm/lib/Analysis/TargetTransformInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,11 @@ bool llvm::TargetTransformInfo::isAlwaysUniform(const Value *V) const {
return TTIImpl->isAlwaysUniform(V);
}

InstructionUniformity
llvm::TargetTransformInfo::getInstructionUniformity(const Value *V) const {
return TTIImpl->getInstructionUniformity(V);
}

bool llvm::TargetTransformInfo::isValidAddrSpaceCast(unsigned FromAS,
unsigned ToAS) const {
return TTIImpl->isValidAddrSpaceCast(FromAS, ToAS);
Expand Down
17 changes: 12 additions & 5 deletions llvm/lib/Analysis/UniformityAnalysis.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,22 @@ bool llvm::GenericUniformityAnalysisImpl<SSAContext>::markDefsDivergent(

template <> void llvm::GenericUniformityAnalysisImpl<SSAContext>::initialize() {
for (auto &I : instructions(F)) {
if (TTI->isSourceOfDivergence(&I))
markDivergent(I);
else if (TTI->isAlwaysUniform(&I))
InstructionUniformity IU = TTI->getInstructionUniformity(&I);
switch (IU) {
case InstructionUniformity::AlwaysUniform:
addUniformOverride(I);
continue;
case InstructionUniformity::NeverUniform:
markDivergent(I);
continue;
case InstructionUniformity::Default:
break;
}
}
for (auto &Arg : F.args()) {
if (TTI->isSourceOfDivergence(&Arg)) {
if (TTI->getInstructionUniformity(&Arg) ==
InstructionUniformity::NeverUniform)
markDivergent(&Arg);
}
}
}

Expand Down
13 changes: 8 additions & 5 deletions llvm/lib/CodeGen/MachineUniformityAnalysis.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,16 @@ void llvm::GenericUniformityAnalysisImpl<MachineSSAContext>::initialize() {
for (const MachineBasicBlock &block : F) {
for (const MachineInstr &instr : block) {
auto uniformity = InstrInfo.getInstructionUniformity(instr);
if (uniformity == InstructionUniformity::AlwaysUniform) {
addUniformOverride(instr);
continue;
}

if (uniformity == InstructionUniformity::NeverUniform) {
switch (uniformity) {
case InstructionUniformity::AlwaysUniform:
addUniformOverride(instr);
break;
case InstructionUniformity::NeverUniform:
markDivergent(instr);
break;
case InstructionUniformity::Default:
break;
}
}
}
Expand Down
11 changes: 11 additions & 0 deletions llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1574,3 +1574,14 @@ unsigned GCNTTIImpl::getNumberOfParts(Type *Tp) const {
}
return BaseT::getNumberOfParts(Tp);
}

InstructionUniformity
GCNTTIImpl::getInstructionUniformity(const Value *V) const {
if (isAlwaysUniform(V))
return InstructionUniformity::AlwaysUniform;

if (isSourceOfDivergence(V))
return InstructionUniformity::NeverUniform;

return InstructionUniformity::Default;
}
2 changes: 2 additions & 0 deletions llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,8 @@ class GCNTTIImpl final : public BasicTTIImplBase<GCNTTIImpl> {
/// together under a single i32 value. Otherwise fall back to base
/// implementation.
unsigned getNumberOfParts(Type *Tp) const override;

InstructionUniformity getInstructionUniformity(const Value *V) const override;
};

} // end namespace llvm
Expand Down
8 changes: 8 additions & 0 deletions llvm/lib/Target/NVPTX/NVPTXTargetTransformInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -635,3 +635,11 @@ void NVPTXTTIImpl::collectKernelLaunchBounds(
if (MaxNTID.size() > 2)
LB.push_back({"maxntidz", MaxNTID[2]});
}

InstructionUniformity
NVPTXTTIImpl::getInstructionUniformity(const Value *V) const {
if (isSourceOfDivergence(V))
return InstructionUniformity::NeverUniform;

return InstructionUniformity::Default;
}
2 changes: 2 additions & 0 deletions llvm/lib/Target/NVPTX/NVPTXTargetTransformInfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,8 @@ class NVPTXTTIImpl final : public BasicTTIImplBase<NVPTXTTIImpl> {
// Self-referential globals are not supported.
return false;
}

InstructionUniformity getInstructionUniformity(const Value *V) const override;
};

} // end namespace llvm
Expand Down