Skip to content

[dsymutil] Add missing validation for zero alignment section #168925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2025
+4 −4
Merged

[dsymutil] Add missing validation for zero alignment section #168925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions llvm/tools/dsymutil/MachOUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,11 +339,11 @@ static bool createDwarfSegment(const MCAssembler& Asm,uint64_t VMAddr, uint64_t
if (Alignment > 1) {
VMAddr = alignTo(VMAddr, Alignment);
FileOffset = alignTo(FileOffset, Alignment);
if (FileOffset > UINT32_MAX)
return error("section " + Sec->getName() +
"'s file offset exceeds 4GB."
" Refusing to produce an invalid Mach-O file.");
}
if (FileOffset > UINT32_MAX)
return error("section " + Sec->getName() +
"'s file offset exceeds 4GB."
" Refusing to produce an invalid Mach-O file.");
Writer.writeSection(Asm, *Sec, VMAddr, FileOffset, 0, 0, 0);

FileOffset += Asm.getSectionAddressSize(*Sec);
Expand Down