[libc] Add missing dependencies for arpa/inet.h header. #168951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dependency on headers with `in_addr` and `in_addr_t` type definitions to ensure that these headers will be properly installed by "install-libc" CMake target.
Member
|
@llvm/pr-subscribers-libc Author: Alexey Samsonov (vonosmas) ChangesAdd dependency on headers with Full diff: https://github.com/llvm/llvm-project/pull/168951.diff 1 Files Affected:
diff --git a/libc/include/CMakeLists.txt b/libc/include/CMakeLists.txt
index 7b52daf9a8062..96c3a88f3fcc8 100644
--- a/libc/include/CMakeLists.txt
+++ b/libc/include/CMakeLists.txt
@@ -200,6 +200,8 @@ add_header_macro(
DEPENDS
.llvm_libc_common_h
.inttypes
+ .llvm-libc-types.in_addr
+ .llvm-libc-types.in_addr_t
)
file(MAKE_DIRECTORY ${LIBC_INCLUDE_DIR}/netinet)
|
lntue
approved these changes
Nov 20, 2025
🐧 Linux x64 Test ResultsThe build succeeded and no tests ran. This is expected in some build configurations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dependency on headers with
in_addrandin_addr_ttype definitions to ensure that these headers will be properly installed by "install-libc" CMake target.