[Github] Remove use of setup-windows and install-ninja in llvm tests #168987
+1
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workflow is only used for libclang and SPIRV tests (and is completely removed in main). Remove install-ninja and setup-windows (only needed on non-Linux) so that we can remove them from llvm/actions.
Member
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis workflow is only used for libclang and SPIRV tests (and is completely removed in main). Remove install-ninja and setup-windows (only needed on non-Linux) so that we can remove them from llvm/actions. Full diff: https://github.com/llvm/llvm-project/pull/168987.diff 1 Files Affected:
diff --git a/.github/workflows/llvm-project-tests.yml b/.github/workflows/llvm-project-tests.yml
index d40ed5babb459..b68e9493ce9c7 100644
--- a/.github/workflows/llvm-project-tests.yml
+++ b/.github/workflows/llvm-project-tests.yml
@@ -37,9 +37,7 @@ on:
os_list:
required: false
type: string
- # Use windows-2019 due to:
- # https://developercommunity.visualstudio.com/t/Prev-Issue---with-__assume-isnan-/1597317
- default: '["ubuntu-24.04", "windows-2019", "macOS-13"]'
+ default: '["ubuntu-24.04"]'
python_version:
required: false
@@ -67,11 +65,6 @@ jobs:
matrix:
os: ${{ fromJSON(inputs.os_list) }}
steps:
- - name: Setup Windows
- if: startsWith(matrix.os, 'windows')
- uses: llvm/actions/setup-windows@main
- with:
- arch: amd64
# On Windows, starting with win19/20220814.1, cmake choose the 32-bit
# python3.10.6 libraries instead of the 64-bit libraries when building
# lldb. Using this setup-python action to make 3.10 the default
@@ -80,9 +73,6 @@ jobs:
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
with:
python-version: ${{ inputs.python_version }}
- - name: Install Ninja
- if: runner.os != 'Linux'
- uses: llvm/actions/install-ninja@main
# actions/checkout deletes any existing files in the new git directory,
# so this needs to either run before ccache-action or it has to use
# clean: false.
|
boomanaiden154
added a commit
to boomanaiden154/actions
that referenced
this pull request
Nov 21, 2025
All uses of these actions in the monorepo have since been removed. This depends on the following PRs landing to ensure things keep working in the release branch: 1. llvm/llvm-project#168987 2. llvm/llvm-project#168985
Collaborator
|
Is llvm-project-tests still used? I wonder if we can just delete the whole file? |
Contributor
Author
In the release branch, yes. We haven't back ported the patches to fully remove it. Not sure it's worth doing that for just the SPIRV/libclang tests. |
tstellar
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow is only used for libclang and SPIRV tests (and is completely removed in main). Remove install-ninja and setup-windows (only needed on non-Linux) so that we can remove them from llvm/actions.